Hi,

On Sat, 12 Feb 2011, Stéphane Glondu wrote:
> After dpkg-source applies patches in a 3.0 (quilt) format, I end up
> with files like this:
> 
>   File: « src/findlib/findlib_config.mlp »
>   Size: 628             Blocks: 8          IO Block: 65536  fichier
> Device: 16h/22d         Inode: 1756876     Links: 1
> Access: (0644/-rw-r--r--)  Uid: ( 1000/   steph)   Gid: ( 1000/   steph)
> Access: 2011-02-12 11:23:46.000000000 +0100
> Modify: 2011-02-12 11:23:46.000000000 +0100
> Change: 2011-02-12 11:22:30.260777840 +0100
>   File: « src/findlib/findlib.ml »
>   Size: 9814            Blocks: 24         IO Block: 65536  fichier
> Device: 16h/22d         Inode: 1756875     Links: 1
> Access: (0644/-rw-r--r--)  Uid: ( 1000/   steph)   Gid: ( 1000/   steph)
> Access: 2011-02-12 11:23:46.000000000 +0100
> Modify: 2011-02-12 11:23:46.000000000 +0100
> Change: 2011-02-12 11:22:30.260777840 +0100
> 
> This triggers an infinite loop in the upstream build system of the
> package. "touch"-ing explicitly the patched files in debian/rules
> fixes the issue, and patching files directly with quilt updates all
> three timestamps, so I guess this is a bug in dpkg-source...

It's not clear to me what the problem is... dpkg-source uses utime() to
reset the timestamps after it has applied the patches so that all the
modified files have the same timestamp. See code in
Dpkg::Source::Patch::apply().

AFAIK the ctime can't be modified except if we do things like chown/chmod
on the file. I don't see why "quilt push" would modify it...

I would argue that your package is broken rather than dpkg-source.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Follow my Debian News ▶ http://RaphaelHertzog.com (English)
                      ▶ http://RaphaelHertzog.fr (Français)




--
To UNSUBSCRIBE, email to debian-dpkg-bugs-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to