tag 613023 pending
thanks
Hello,
Bug #613023 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:
http://git.debian.org/?p=dpkg/dpkg.git;a=commitdiff;h=255e73e
---
commit 255e73e11d1365fbb1e8d78287fad751a8ebc6e5
Author: Jonathan Nieder <jrnie...@gmail.com>
Date: Mon Feb 14 06:39:03 2011 -0600
dpkg-source: use server-side clock for patched file timestamp on NFS
Since 1.13.14~20 (2006-02-10), dpkg-source touches the files it
patches when unpacking, with a single date. This way, the order of
mtimes does not depend on the order in which the files were patched,
which is convenient when e.g. configure.in and configure are patched.
More precisely, dpkg-source does something like the following:
my $now = time();
foreach my $fn (@patched_files) {
utime($now, $now, $fn);
}
Unfortunately when the filesystem is NFS, "touch" and normal
modification set mtime and atime to the current time on the server
side, while time() returns the current time on the client side.
The two clocks can disagree, producing breakage.
So unless a timestamp has been passed explicitly, use utime(undef,
undef, $fn) to set mtime for the first file to the server side time
and copy it (rounded down to a number of seconds) to all patched
files.
Reported-by: Stéphane Glondu <glo...@debian.org>
Signed-off-by: Jonathan Nieder <jrnie...@gmail.com>
Improved-by: Raphaël Hertzog <hert...@debian.org>
Signed-off-by: Raphaël Hertzog <hert...@debian.org>
diff --git a/debian/changelog b/debian/changelog
index 9175e77..e6ed337 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -68,6 +68,11 @@ dpkg (1.16.0) UNRELEASED; urgency=low
* dpkg-source now keeps the file ordering in the autogenerated patch when
regenerating it. Closes: #606080
Thanks to Colin Watson for the patch.
+ * dpkg-source now uses a timestamp retrieved from the filesystem when
+ resetting the timestamp of patched files so that a time skew when using
+ NFS doesn't introduce any inconsistency. Closes: #613023
+ Thanks to Jonathan Nieder <jrnie...@gmail.com> for the patch and the
+ diagnosis.
[ Jonathan Nieder ]
* Remove support for use of synchronous sync(2), due to its pernicious
--
To UNSUBSCRIBE, email to debian-dpkg-bugs-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
