On Sat, 2012-05-26 at 16:03:01 -0500, Jonathan Nieder wrote:
> Package: dpkg
> Version: 1.16.3
> Severity: important
> Justification: http://bugs.debian.org/673283

> In debhelper 9.20120513 and later, dh_builddeb passes the options -z1
> -Zxz -Sextreme to dpkg-deb when building udebs.  Unfortunately this
> means there is no way to use a different compression type if the
> packager prefers to do so:
> 
>  dh_builddeb -- -Zgzip -z9
>  dpkg-deb: building package `btrfs-tools' in 
> `../btrfs-tools_0.19+20120328-1_amd64.deb'.
>  dpkg-deb: building package `btrfs-tools-dbg' in 
> `../btrfs-tools-dbg_0.19+20120328-1_amd64.deb'.
>  dpkg-deb: error: invalid compressor parameters: unknown compression strategy
> [...]
>  dh_builddeb: dpkg-deb -z1 -Zxz -Sextreme -Zgzip -z9 --build 
> debian/btrfs-tools-udeb ../btrfs-tools-udeb_0.19+20120328-1_amd64.udeb 
> returned exit code 2
> 
> Once a strategy has been set to "extreme" with -S, there is no way for
> the packager to return to the default strategy using another option.
> Compression types other than xz do not accept the extreme strategy, so
> the upshot is that they cannot be used for udebs.

I've started reworking a bit the strategy logic, for starters I'm
adding a "none" strategy so that it can be reset explicitly.

> Here's a patch to address that.  Strategies are only meaningful in the
> context of a particular compression type, so this patch teaches the -Z
> option to reset the strategy to the default.
>
> Without this change "dpkg-deb -Sextreme -Zxz" uses the extreme
> strategy and this change breaks that.  A quick Google search does not
> reveal anyone using those options out of order, but if there's a clean
> way to avoid breaking the interface then I'd be interested.  (For
> example, maybe the first -Z option should not reset the strategy,
> while later ones would?  I can imagine the result being very
> confusing.)

Yeah, I'm not very thrilled with the behaviour changing depending on
the relative order of the -Z and -S options. Same options being
overridden by later instances seems fine though. I'll think about what
else might be feasible to do for a bit.

thanks,
guillem



-- 
To UNSUBSCRIBE, email to debian-dpkg-bugs-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to