tags 677631 + confirmed
quit
Niels Thykier wrote:
> $ env -uHOME dpkg-source -x lintian_2.5.7.dsc
> Use of uninitialized value $ENV{"HOME"} in concatenation (.) or string at
> /usr/share/perl5/Dpkg/Source/Package.pm line 351.
[...]
> Please see attached patch as a possible solution.
[...]
> --- a/scripts/Dpkg/Source/Package.pm
> +++ b/scripts/Dpkg/Source/Package.pm
> @@ -349,7 +349,7 @@ sub check_signature {
> push @exec, "gpg", "--no-default-keyring", "-q", "--verify";
> }
> if (scalar(@exec)) {
> - if (-r "$ENV{'HOME'}/.gnupg/trustedkeys.gpg") {
> + if (defined $ENV{'HOME'} and -r
> "$ENV{'HOME'}/.gnupg/trustedkeys.gpg") {
> push @exec, "--keyring", "$ENV{'HOME'}/.gnupg/trustedkeys.gpg";
For what it's worth,
Reviewed-by: Jonathan Nieder <jrnie...@gmail.com>
The house style would be to use "if ($ENV{'HOME}' and -r ..." but I think
the behavior here is better anyway in odd cases like HOME=0.
Thanks,
Jonathan
--
To UNSUBSCRIBE, email to debian-dpkg-bugs-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
