On 2012-07-16 23:02, Guillem Jover wrote: > On Mon, 2012-07-16 at 22:04:57 -0400, P. J. McDermott wrote: >> The patch does not verify that the profile chosen by the user is >> actually specified in the package's control file. I'm not sure if (or >> where) that should be done, but it would be fairly easy to do by listing >> the "profiles" keys of all build dependencies. Is similar checking done >> for the host arch? > > No, the builder should be able to use those unconditionally regardless > of the package having this kind of specifications, otherwise you'd > need to know if the package uses them to be able to first set the > flags, which does not really scale.
Yes, I thought that might be the case. > Also the debian/rules could change > say configure options depending on the profile, and that's something > the dpkg tools would not be able to detect anyway. Ah, yes, good point. The detection I had in mind would have only considered the Build-* control fields (which -- along with such configure options, pkg-config variables, etc. -- is how we're doing staged builds). >> So although I'm not proposing this for immediate inclusion, we'd >> appreciate feedback on the design and implementation. > > Before I'll consider including something like this, the aforementioned > deployment to see if it really covers all your needs would be nice, > and after that we'd need to propose and discuss this in for example > debian-devel, because other software will need to be adapted to > support the new syntax. Sounds good to me. I've already modified sbuild to use the new profile reduction in Dpkg::Deps, though I've yet to test and publish the patch. I also started looking at what'll need done in APT. > I'll try to give a more detailed review of > the code in few days. Alright, great. Thanks for the feedback, -- P. J. McDermott (_/@\_) ,--. http://www.pehjota.net/ o < o o > / oo \ http://www.pehjota.net/contact.html o \ `-/ | <> |. o o o "~v /_\--/_/ -- To UNSUBSCRIBE, email to debian-dpkg-bugs-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
