Hi! On Wed, 2012-12-19 at 10:40:25 +0100, Guillem Jover wrote: > On Tue, 2012-12-18 at 18:17:23 +0100, Matthijs Kooijman wrote: > > This provides some examples on using dpkg-buildflags and buildflags.mk > > in debian/rules, notes that --export=make is not recommended and > > explicitly mentions that the list of build flags is subject to change. > > > > Closes: #657627 > > Thanks for the patch. I'll look how to best combine this with the patch > Jonathan provided in #691449 (which is sitting in my local tree) in the > coming days.
On Mon, 2012-10-29 at 01:12:34 +0100, Guillem Jover wrote: > On Sun, 2012-10-28 at 02:53:57 -0700, Jonathan Nieder wrote: > > That's fair. I first tried putting this in the description of the > > --export option but it felt too long. > > Right, I see what you mean. But what seems to me to be clutterering > it a bit, are the examples. :) > > > It didn't seem right in the examples section, either, because the > > examples don't illustrate other aspects of how to use dpkg-buildflags > > properly (for example, the text doesn't mention bug#327154). > > Oh, sure, although I do think adding a note for the $(shell) issue > and an example for that would be worthwile (or other caveats or usage > patterns you might have in mind?), afterall this kind of shell quoting > stuff seems to usually trip people over. > > > Here's another try at putting it in the description of --export. What > > do you think? > > Certainly an improvement, although I'm not yet sold on the embedded > examples, it would probably also make more sense to format them all > in the same way too. And thanks for bearing with my pickyness? :) Ok, I've merged these two patches with some modifications, you can see the result in: <http://anonscm.debian.org/gitweb/?p=dpkg/dpkg.git;a=blob;f=man/dpkg-buildflags.1;hb=HEAD> The commits: <http://anonscm.debian.org/gitweb/?p=dpkg/dpkg.git;a=commitdiff;h=eb25201f1dc115d2cc9652ed0213d80806f1ca03> <http://anonscm.debian.org/gitweb/?p=dpkg/dpkg.git;a=commitdiff;h=6f95a795d310d35d89b1060406236d81dd9b8da0> Please, let me know if it looks good to you? Jonathan, I'll try to add a mention of #327154 too, if no one provides a patch first. :) Thanks, Guillem -- To UNSUBSCRIBE, email to debian-dpkg-bugs-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
