Hi! On Sat, 2014-09-27 at 10:47:09 +0800, Paul Wise wrote: > On Fri, 2014-09-26 at 19:30 +0200, Guillem Jover wrote: > > Meanwhile I've added support to dpkg-buildflags to honor feature area > > settings from DEB_BUILD_OPTIONS, so that these can be enabled globally by > > a builder for example for build tests and similar, but will be overridden > > by DEB_BUILD_MAINT_OPTIONS though (in the same way build flags are). > > Thanks.
Which requires a call to _parse_feature_area(), which I forgot to mention in my previous mail. I've added it locally now. > > I'm thinking that if this gets accepted by the project at large, then > > it might even make sense to make it an error (-Werror=date-time) at > > some later point, so the name would be wrong. How about 'timeless'? > > Or can you think about some other more appropriate name? > > I wasn't aware of the -Werror=date-time flag, thanks for pointing it > out. We should indeed transition to making it an error at some point. The -Werror=option is a generic variant to -Woption, it just turns any such warning option into an error. > > It would be nice if you could add documentation in the dpkg-buildflags > > man page, a new .SS subsection, with something along the lines of the > > first Hardening paragraph (I had already reworked the common parts out > > of the Hardening subsection for other feature areas, so no need to > > repeat those). > > Updated each of the patches to include documentation updates too. Cool, thanks! I've merged this now locally, it will be included in dpkg 1.17.14. I ended up doing some very minor tweaks, like prefixing the add_reproducible_flags with an _ to mark it as private, or rewording a bit the commit message. Thanks, Guillem -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
