Guillem Jover writes ("Re: Bug#908742: Want way to reset tar-ignore list"):
> Hmm, I found this bug description and the problem from the referenced
> bug to be a bit of a mismatch. I checked the notmuch referenced history
> where I noticed in commit 514fb397c9f7cfc80f0b14bd28bb2acdb4cd30ca that
> the problem was the standalone tar-ignore option. The current options
> file now contains:
>
> ,--- debian/source/options
> single-debian-patch
> tar-ignore=.git
> tar-ignore=performance-test/download/*.tar.xz
> `---
Yes. From the point of view of dgit's call to dpkg-source, that's a
workaround, really. (From the point of view of other uses of notmuch
I think it is a bugfix, or a workaround for #908747, depending on how
you look at things.)
> With that in mind, I'm not sure whether your request is to ignore
> *only* those standalone tar-ignore options or any of them regarldess
> of these taking an argument or not?
No, dgit wants to completely control the ignore list.
> Because I'd think in general you'd want to honor the ignore rules from
> the source package itself, except for the dpkg-source defaults. OTOH I
> guess those same ignores would be covered by things such as .gitignore
> or similar VCS-specific files.
dgit is working from a git commit and therefore has a git tree object
which already contains exactly the right set of files. (That tree
object may have been influenced by .gitignore but that happened
earlier.) dgit needs to convert that into a source package, so it
calls dpkg-source.
So dgit needs represent in the source package exactly all files that
are in the tree object, regardless of the contents of the
debian/source/options.
If the tree object contains files which were ignored by a tar-ignore
implied by debian/source/options, then that is arguably some kind of
bug, but dgit needs to be able to work with buggy source packages
which appear in the actually-existing archive, and with commits (and
trees) made by downstream users who do not understand (or perhaps even
agree with) the maintainer's debian/source/options and the implied
tar-ignore.
> I think both options, never-add-tar-ignore-defaults-even-if-specified
> and clear-all-tar-ignore are valid, and I might add both, just wanted
> to make sure I understand which one you are requesting here.
So I think I want --clear-all-tar-ignore.
Thanks,
Ian.
--
Ian Jackson <ijack...@chiark.greenend.org.uk> These opinions are my own.
If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.
