Package: dpkg
Version: 1.19.2
Severity: normal

Hi,

The dpkg-mergechangelogs utility strips vim modelines (etc). I
discovered this in lintian which has a trailing "vim: et" at the end
of the file.

This is, of course, caused by:

          } elsif (m/^vim:/io) {
            last; # skip Vim modelines at end of file

… in "scripts/Dpkg/Changelog/Debian.pm". I'm not sure what can be done
about this however without introducing a special mode/option to the
parsing code, however.

Thoughts?

§

A simple testcase for this issue is:

  --- a/scripts/t/merge_changelogs/c]h-a
  +++ b/scripts/t/merge_changelogs/ch-a
  @@ -90,3 +90,5 @@ test (1.0-1) unstable; urgency=low
     * Initial release. (Closes: #XXXXXX)
   
    -- Raphaël Hertzog <hert...@debian.org>  Sun, 18 Apr 2010 17:37:46 +0200
  +
  +vim: et
  diff --git a/scripts/t/merge_changelogs/ch-b b/scripts/t/merge_changelogs/ch-b
  index 9eb7869..a74145f 100644
  --- a/scripts/t/merge_changelogs/ch-b
  +++ b/scripts/t/merge_changelogs/ch-b
  @@ -85,3 +85,5 @@ test (1.0-1) unstable; urgency=low
     * Initial release. (Closes: #XXXXXX)
   
    -- Raphaël Hertzog <hert...@debian.org>  Sun, 18 Apr 2010 17:37:46 +0200
  +
  +vim: et
  diff --git a/scripts/t/merge_changelogs/ch-old 
b/scripts/t/merge_changelogs/ch-old
  index 12ee224..5ff7dd3 100644
  --- a/scripts/t/merge_changelogs/ch-old
  +++ b/scripts/t/merge_changelogs/ch-old
  @@ -83,3 +83,5 @@ test (1.0-1) unstable; urgency=low
     * Initial release. (Closes: #XXXXXX)
   
    -- Raphaël Hertzog <hert...@debian.org>  Sun, 18 Apr 2010 17:37:46 +0200
  +
  +vim: et


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-

Reply via email to