Your message dated Tue, 22 Jan 2019 18:49:41 +0000
with message-id <e1gm17f-000isx...@fasolo.debian.org>
and subject line Bug#910734: fixed in dpkg 1.19.3
has caused the Debian Bug report #910734,
regarding dpkg-source: please expand @builddeps@ in Testsuite-Triggers
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
910734: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910734
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: dpkg-dev
Version: 1.19.1
Severity: wishlist
X-Debbugs-Cc: debian...@lists.debian.org
Dear maintainer,
From to dsc(5):
Testsuite-Triggers: package-list
This field declares the comma-separated union of all test dependencies
(Depends fields in debian/tests/control file), with all restrictions
removed, and OR dependencies flattened (that is, converted to separate AND
relationships), except for binaries generated by this source package and
meta-dependencies such as @ or @builddeps@.
That says that the special value @builddeps@ is ignored for the purposes
of the generation of this field.
I've come to consider this as a issue, as our testing migration software
is not considering build-dependencies as useful (much less needed)
triggers for the testsuite (aka autopkgtest, for the purposes of this
conversation).
I found @builddeps@ useful in multiple occasions, to avoid duplicating
—potentially for a third(!) time— a list of packages; but the lack of
triggers for those is annoying me, and reducing the usefulness of the
testsuite for testing migration purposes.
A practical example here could be src:limnoria, at the version
2018.09.09-1. That thing uses @builddeps@ to avoid duplicating packages
that are already listed in Build-Depends and in Recommends, but as a
result, the tests are triggered very very rarely, only for the direct
dependency src:python3-defaults and src:limnoria itself.
Informally talking on IRC revealed the following concerns:
1. duplicating the build-dependencies in the triggers has the potential
to bloat the Sources index file even more
2. this could be a job better done by the testing migration software, by
e.g. always triggering tests for changing build-dependencies, like it
already does for changing direct dependencies
3. it would potentially cause useless test runs for things like changed
debhelper or other build tools that unlikely would change the
run-time behaviour of the software
IMHO, concerns 1. and 2. could be taken care of by not expanding
@builddeps@ inside Testsuite-Triggers, but instead having it copied
as-is, and then the testing migration software would expand it while
evaluating the triggers. This would also avoid needless test runs as
they would happen as proposed in concern 2. if all packages had their
build-dependencies trigger tests (however there is a valid idea here
maybe). I also don't think concern 3. is valid: the extra resources
used would hardly matter in my opinion.
For what my proposal here is concerned, if @builddeps@ end up expanded
in Testsuite-Triggers, it should be flattened like the rest of the
dependencies listed directly in the Depends field of d/tests/control.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
Source: dpkg
Source-Version: 1.19.3
We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 910...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Guillem Jover <guil...@debian.org> (supplier of updated dpkg package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Tue, 22 Jan 2019 14:26:04 +0100
Source: dpkg
Architecture: source
Version: 1.19.3
Distribution: unstable
Urgency: medium
Maintainer: Dpkg Developers <debian-d...@lists.debian.org>
Changed-By: Guillem Jover <guil...@debian.org>
Closes: 810724 818618 854478 901127 910707 910734 910819 911620 912023 912024
913012 913816 914478 915610 915881 916056 916456 916799 917098 917813
Changes:
dpkg (1.19.3) unstable; urgency=medium
.
[ Guillem Jover ]
* dpkg-source: Stop filtering @builddeps@ from Testsuite-Triggers field.
Closes: #910734
* dpkg-genchanges: Only reference binary packages being uploaded, which
means that for a source-only upload, the Binary and Description fields
should be empty. Closes: #818618
* dpkg-scanpackages: Do not compute unnecessary checksums when using the
--hash argument. Based on a patch by Chris Lamb <la...@debian.org>.
Closes: #916456
* dpkg-scanpackages: Emit a warning with the list of repeat packages.
Prompted by Johannes Schauer <jo...@debian.org>.
* start-stop-daemon: Check whether standalone --pidfile use is secure.
Prompted by Michael Orlitzky <mich...@orlitzky.com>.
* start-stop-daemon: Print complete verbose lines, instead of partial lines
with no newlines and a final print with a newline.
* start-stop-daemon: Add new --notify-await and --notify-timeout options,
which implement the systemd readiness protocol for services.
Closes: #910707
* update-alternatives: Add new --debug option.
* update-alternatives: Fix removal of obsolete slaves from the linked list.
Reported by Andreas Beckmann <a...@debian.org>. Closes: #916799
* vendor.mk: Fix dpkg_vendor_derives_from macro documentation.
Thanks to Colin Watson <cjwat...@debian.org>. Closes: #913816
* vendor.mk: Add support for an improved dpkg_vendor_derives_from macro.
Version the macros so that both can be used, and default the unversioned
one to the version 0 macro.
* dpkg: Mark the package we are giving up on a trigger cycle as "istobe"
normal, so that the dependency checks know they cannot expect this package
to be processed anymore. Otherwise we ended up never detecting that we
were not making progress, as we expected to process this package at a later
point, when that would never happen anymore. This then was causing asserts
in the process queue loop. Closes: #901127, #910819
* dpkg: Reset progress_bytrigproc once we have injected it into the current
package process queue iteration, so that we do not keep trying to process
it, which might end up generating artificial trigger cycles, if
dependencies are not satisfied yet.
* dpkg: Convert one trigger processing required type into the new try-queued
one, so that we stop skipping unsatisfiable dependency checks.
* dpkg: Move trigproc cycle reset inside try-deferred conditional. We should
only reset the cycle detection in case we are not bailing out from the
processing with an error, otherwise we could come back to this package and
detect an artificial trigger cycle.
* dpkg: Introduce a new dependency try level for trigger processing. This
completely defers trigger processing until after the dependency cycle
breaking level, so to avoid generating artificial trigger cycles, when we
end up trying to process triggers with yet unsatisifiable dependencies.
Closes: #810724, #854478, #911620
* dpkg: Fix --help output, to clarify which arguments are optional.
* libdpkg: Add proper tar error handling. This makes the tar extractor
track and report back parse errors, so that we can give more descriptive
messages.
* libdpkg: Detect unsupported tar entry types to give better error messages.
* libdpkg: Add new db-fsys:Files and db-fsys:Last-Modified virtual fields.
* Perl modules:
- Dpkg::Changelog::Debian: Preserve modelines at EOF. Closes: #916056
Thanks to Chris Lamb <la...@debian.org> for initial test cases.
- Dpkg::File: Make file_slurp() also accept pathnames in addition to
filehandles.
- Dpkg::Vendor::Ubuntu: Fix buildflags override after default setting move.
Based on a patch by Iain Lane <la...@ubuntu.com> and
Adam Conrad <adcon...@ubuntu.com>. Closes: #915881
- Dpkg::Shlibs::Objdump: Remove unused Dpkg::IPC import.
- Dpkg::Shlibs::Objdump: Only select objdump program when going to use it.
- Dpkg::Source::Package: Do not reinitialize fields member in constructor.
- Dpkg::Source::Patch: Do not recommend --include-removal when not
supported. Closes: #913012
- Dpkg::Source::Package::V3::Bzr: Fix format name in output message.
- Dpkg::Source::Package: Add a new format option to the new constructor.
Prompted by James McCoy <jame...@debian.org>.
- Dpkg::Source::Package: Improve debian/source/format parsing and
validation.
- Dpkg::Source::Format: New public module.
Prompted by Mattia Rizzolo <mat...@debian.org>.
* Documentation:
- dpkg(1): Clarify --remove action. Closes: #914478
- dpkg-query(1): Clarify --list option behavior when no arguments are
specified. Closes: #917098
- deb-control(5): Clarify by adding a reference to deb-src-control(5) and
removing an invalid comment in the example.
Prompted by Helmut Grohne <hel...@subdivi.de>.
- dpkg(1): Clarify databases used by --yet-to-unpack and --predep-package.
Prompted by Johannes Schauer <jo...@debian.org>.
- Clarify character classes for various formats in man pages, by
explicitly listing the character ranges within parenthesis.
Prompted by Ian Jackson <ijack...@chiark.greenend.org.uk>.
- dpkg-query(1): Document the version introducing the -f option.
- dpkg-architecture(1): Add reference to the TERMS section in the
VARIABLES section. Prompted by Axel Beckert <a...@debian.org>.
- Fix POD for Dpkg::Interface::Storable derived method implementations.
- Dpkg::Deps::Simple(3): Fix POD signature for new constructor.
* Code internals:
- dpkg-maintscript-helper: Use an explicit escape instead of a literal
backslash.
- Quote shell variables. Reported by Johannes Schauer <jo...@debian.org>.
- Switch perl code to use the new Dpkg::Source::Format module.
- dpkg-source: Move source format selection earlier in the build.
- dpkg-source: Use new format argument for Dpkg::Source::Package->new().
- dpkg-shlibdeps: Remove unused variable.
- dpkg-scanpackages: Unroll a single iteration loop.
- start-stop-daemon: Compare foundany against 0 instead of treating it
like a boolean.
- start-stop-daemon: Switch code to use new info() and debug() functions.
- update-alternatives: Use enums for actions instead of strings.
- update-alternatives: Switch verbose selection into an enum.
- dpkg: Negate tortoise_not_in_hare() function name and return value.
- dpkg: Initialize trigcyclenode's next member once.
- dpkg: Use common pattern of assigning as an iterator.
- dpkg: Factor trigproc_new_cyclenode() out from check_trigger_cycle().
- dpkg: Switch dependtry from an int to an enum.
- dpkg: Move dependtry description from deferred_configure() to its
declaration.
- dpkg: Split trigger processing types into required, try-queued and
try-deferred.
- dpkg-query: Rename variable to avoid shadowing a local function.
- When allocating use the variable instead of the type in sizeof().
- dselect: Rename variable r to pkgbin.
- libdpkg, dpkg: Rename r variables to fnn.
- libdpkg: Rename ret variable to next.
- libdpkg: Cleanup fsys module symbol names.
- libdpkg: Rename pkg_db symbols to pkg_hash.
- libdpkg: Add new warning printer setter function.
Prompted by Julian Andres Klode <j...@debian.org>.
- libdpkg: Add new DPKG_ERROR_OBJECT macro.
* Build system:
- get-version: Use a format string with printf.
- run-script: Use $() instead of deprecated ``.
- run-script: Remove unused PERL_PROFILE variable, PERL5OPT can be used
instead, and does not require leaving an unquoted variable around.
- run-script: Add «set -e».
- Build.PL: Set environment variables only for CPAN tests.
- Build.PL: Set locale for CPAN tests to C. Fixes CPAN#127314.
- configure: Split AM_INIT_AUTOMAKE arguments into different lines.
* Packaging:
- Bump Standards-Version to 4.2.1 (no changes needed).
- Switch to debhelper compatibility level 11.
- Create the log file in postinst only if it does not exist.
Prompted by Johannes Schauer <jo...@debian.org>.
- Add superficial autopkgtest functional tests.
* Test suite:
- Add new shellcheck author test.
- Add descriptions for the shellcheck exclude codes.
- Update cppcheck supressions.
.
[ Updated programs translations ]
* Dutch (Frans Spiesschaert). Closes: #912023
* German (Sven Joachim).
* Italian (Milo Casagrande). Closes: #915610
* Portuguese (Miguel Figueiredo). Closes: #917813
.
[ Updated scripts translations ]
* German (Helge Kreutzmann).
.
[ Updated man pages translations ]
* Dutch (Frans Spiesschaert). Closes: #912024
* German (Helge Kreutzmann).
Checksums-Sha1:
00e0edb18fe52e586c61dd6d116608b20ff3455f 2079 dpkg_1.19.3.dsc
60b173424d2cf0aa691f7c7c3e7097d495b693dd 4644312 dpkg_1.19.3.tar.xz
87c8cd8583e6d248c9f229c5166b36a4d8a64b9b 7193 dpkg_1.19.3_amd64.buildinfo
Checksums-Sha256:
9133bfa22f48d533e9cd39e8d185b956d78994eabccd9c14f590d5e8836c2e1a 2079
dpkg_1.19.3.dsc
6cd3311a18b5d481039bf8d5ca3bc0ef47b035ff6313644cafcd8750a0dd7ac3 4644312
dpkg_1.19.3.tar.xz
8eabbb093345b282630b94906c386c02f511f8baf7c08d9fafc00c5bf8608f0e 7193
dpkg_1.19.3_amd64.buildinfo
Files:
d24dd85da0cd49d0b9b444bc4faa2b49 2079 admin required dpkg_1.19.3.dsc
4716904f65fb5590dd1fbe712e87fbea 4644312 admin required dpkg_1.19.3.tar.xz
cc0d0db9cc4905f5c1f19efccaff943c 7193 admin required
dpkg_1.19.3_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEETz509DYFDBD1aWV0uXK/PqSuV6MFAlxHKGIACgkQuXK/PqSu
V6NeyBAAi9XhcJBTYtTEXHBb3Lf1JtCAXfW/5IsEC8bZAMX5v0/eYeWc6NuTQLM8
AvWxT7XIHLtYu1XUF7s1mei/TFJj9PBpXEIBlJTQNx7xn4fcZBB5Y2bHMJPxRq2c
Q0dZb0lgWm6LXcVZ1J1nNuE0HzRUKxXbWsK2uVezoV1w0A/TWZ1Igu/JvVGUMYP1
0c6DnS1JfihoB5n+iF2KNFeFJrNCvQm63n7Tp0Oea2Bd5an+/RTb/ndOOmNrIuZ8
Be7vEtTyvud368g2YusCcr6RN6nlbLBTZZQLMiLuUx1iXrakN31dRhv7gF7Bw0HW
JgFZoQmmgZ7FcSoq2zbB9SZn4TOUoycQ2PUpd6pANBWNzkIc2Qr2tKj3daJQMLfi
6mMX6U3BxrA/2UQlCs1UznQ4R+nxCfBKpWKmZL890ARuoLJoUyNK0D9j4KN1Ril4
8WxMNQ5Xbk5tJ2XGHf1YiPsfZVUsLTIZMfYd9IwABPo8+NQoh/A0Ag8zj1DIzRpB
0rOqtCFyj7kEg+N8qJ2Gl3n0m0o/fB1IwN2jmoNXE8OYQXi2OUD95JLZOXv7dZOQ
uEmx8MEUcCsSaFd3qBSww+Ug6VSbySBXSEmwkWrSUHEl7p4QgJrXuEy+1VGb/1Tl
6HXCeWNgFY7hu1lJDeNhyKekvM0fIHx/dRZaGHXTHzT5gRIikHc=
=0/kc
-----END PGP SIGNATURE-----
--- End Message ---
