This is an automated email from the git hooks/post-receive script.
guillem pushed a commit to branch master
in repository dpkg.
commit 9fb2b44c59e409bf5541d77fd31c961ef1d01265
Author: Guillem Jover <guil...@debian.org>
Date: Sun Mar 25 01:21:01 2018 +0100
build: Enable clang -Wdocumentation warning if available
Fix a couple of function parameter typos surfaced by the new warning.
Warned-by: clang
---
debian/changelog | 1 +
dpkg-deb/build.c | 8 ++++----
m4/dpkg-compiler.m4 | 1 +
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index b040598..ada2e18 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -72,6 +72,7 @@ dpkg (1.19.1) UNRELEASED; urgency=medium
- Mark PO4A and POD2MAN as precious variables.
- Automatically replace -Wno- with -W when testing compiler flags,
instead of passing the positive form manually.
+ - Enable clang -Wdocumentation warning if available.
* Packaging:
- Install update-alternatives policykit-1 file.
- Add Breaks to libdpkg-perl against pkg-kde-tools (<< 0.15.28~), as
diff --git a/dpkg-deb/build.c b/dpkg-deb/build.c
index 316efeb..68d1875 100644
--- a/dpkg-deb/build.c
+++ b/dpkg-deb/build.c
@@ -313,8 +313,8 @@ check_conffiles(const char *ctrldir, const char *rootdir)
/**
* Check the control file.
*
- * @param dir The directory from where to build the binary package.
- * @return The pkginfo struct from the parsed control file.
+ * @param ctrldir The directory from where to build the binary package.
+ * @return The pkginfo struct from the parsed control file.
*/
static struct pkginfo *
check_control_file(const char *ctrldir)
@@ -343,8 +343,8 @@ check_control_file(const char *ctrldir)
/**
* Perform some sanity checks on the to-be-built package control area.
*
- * @param dir The directory from where to build the binary package.
- * @return The pkginfo struct from the parsed control file.
+ * @param ctrldir The directory from where to build the binary package.
+ * @return The pkginfo struct from the parsed control file.
*/
static struct pkginfo *
check_control_area(const char *ctrldir, const char *rootdir)
diff --git a/m4/dpkg-compiler.m4 b/m4/dpkg-compiler.m4
index 1f9653f..555cc37 100644
--- a/m4/dpkg-compiler.m4
+++ b/m4/dpkg-compiler.m4
@@ -47,6 +47,7 @@ AC_DEFUN([DPKG_CHECK_COMPILER_WARNINGS], [
DPKG_CHECK_COMPILER_FLAG([-Wextra])
DPKG_CHECK_COMPILER_FLAG([-Wcast-align])
+ DPKG_CHECK_COMPILER_FLAG([-Wdocumentation])
DPKG_CHECK_COMPILER_FLAG([-Wduplicated-cond])
DPKG_CHECK_COMPILER_FLAG([-Wformat -Wformat-security])
DPKG_CHECK_COMPILER_FLAG([-Winit-self])
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/dpkg/dpkg.git
