This is an automated email from the git hooks/post-receive script. guillem pushed a commit to branch master in repository dpkg.
View the commit online: https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=a7fb57546f0a7e88a1acd7bdf1c081b43972b01d commit a7fb57546f0a7e88a1acd7bdf1c081b43972b01d Author: Guillem Jover <guil...@debian.org> AuthorDate: Sun Nov 25 22:59:03 2018 +0100 Dpkg::Source::Package: Do not reinitialize fields member in constructor We initialized it already in the new constructor, no point in doing the same twice. --- debian/changelog | 1 + scripts/Dpkg/Source/Package.pm | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/changelog b/debian/changelog index e4d49221e..d43a06258 100644 --- a/debian/changelog +++ b/debian/changelog @@ -11,6 +11,7 @@ dpkg (1.19.3) UNRELEASED; urgency=medium Adam Conrad <adcon...@ubuntu.com>. Closes: #915881 - Dpkg::Shlibs::Objdump: Remove unused Dpkg::IPC import. - Dpkg::Shlibs::Objdump: Only select objdump program when going to use it. + - Dpkg::Source::Package: Do not reinitialize fields member in constructor. * Documentation: - dpkg(1): Clarify --remove action. Closes: #914478 - dpkg-query(1): Clarify --list option behavior when no arguments are diff --git a/scripts/Dpkg/Source/Package.pm b/scripts/Dpkg/Source/Package.pm index f7851d203..c9f8d5e14 100644 --- a/scripts/Dpkg/Source/Package.pm +++ b/scripts/Dpkg/Source/Package.pm @@ -262,9 +262,8 @@ sub initialize { $self->{filename} = $fn; # Read the fields - my $fields = Dpkg::Control->new(type => CTRL_PKG_SRC); + my $fields = $self->{fields}; $fields->load($filename); - $self->{fields} = $fields; $self->{is_signed} = $fields->get_option('is_pgp_signed'); foreach my $f (qw(Source Version Files)) { -- Dpkg.Org's dpkg
