This is an automated email from the git hooks/post-receive script.

guillem pushed a commit to branch main
in repository dpkg.

View the commit online:
https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=f6d286e0d8aff77e09cd69018bc37e9b08483f36

commit f6d286e0d8aff77e09cd69018bc37e9b08483f36
Author: Guillem Jover <guil...@debian.org>
AuthorDate: Sat Mar 4 22:54:11 2023 +0100

    scripts: Remove duplicate variable declaration
    
    Do not shadow an already defined variable, instead simply use it
    as is, given that the other uses will initialize it when needed.
    
    Warned-by: perlcritic
    Addresses: Variables::ProhibitReusedNames
---
 scripts/Dpkg/Shlibs/Symbol.pm | 2 +-
 scripts/t/merge_changelogs.t  | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/Dpkg/Shlibs/Symbol.pm b/scripts/Dpkg/Shlibs/Symbol.pm
index 6a712e168..ca6efaadf 100644
--- a/scripts/Dpkg/Shlibs/Symbol.pm
+++ b/scripts/Dpkg/Shlibs/Symbol.pm
@@ -85,7 +85,7 @@ sub parse_tagspec {
     if ($tagspec =~ /^\s*\((.*?)\)(.*)$/ && $1) {
        # (tag1=t1 value|tag2|...|tagN=tNp)
        # Symbols ()|= cannot appear in the tag names and values
-       my $tagspec = $1;
+       $tagspec = $1;
        my $rest = ($2) ? $2 : '';
        my @tags = split(/\|/, $tagspec);
 
diff --git a/scripts/t/merge_changelogs.t b/scripts/t/merge_changelogs.t
index 3f76d5df6..75209865c 100644
--- a/scripts/t/merge_changelogs.t
+++ b/scripts/t/merge_changelogs.t
@@ -27,7 +27,6 @@ use Dpkg::IPC;
 my $srcdir = $ENV{srcdir} || '.';
 my $datadir = "$srcdir/t/merge_changelogs";
 
-my $res;
 sub test_merge {
     my ($expected_file, @options) = @_;
     my $fh = File::Temp->new();

-- 
Dpkg.Org's dpkg

Reply via email to