This is an automated email from the git hooks/post-receive script.

guillem pushed a commit to branch main
in repository dpkg.

View the commit online:
https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=c954d2cb1f70c834a22044f60197908891eae1f5

commit c954d2cb1f70c834a22044f60197908891eae1f5
Author: Guillem Jover <guil...@debian.org>
AuthorDate: Thu May 11 03:23:26 2023 +0200

    dselect: Fix stdout+stderr discarding redirection in ftp method
    
    The redirections were out of order so only stdout was being discarded.
    
    Prompted-by: shellcheck
---
 dselect/methods/ftp/install.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dselect/methods/ftp/install.pl b/dselect/methods/ftp/install.pl
index 76ed7db7e..ea6ea7160 100755
--- a/dselect/methods/ftp/install.pl
+++ b/dselect/methods/ftp/install.pl
@@ -452,9 +452,9 @@ my %files; # package-version => files...
 sub chkdeb($) {
     my ($fn) = @_;
     # check to see if it is a .deb file
-    if(!system("dpkg-deb --info $fn 2>&1 >/dev/null && dpkg-deb --contents $fn 
2>&1 >/dev/null")) {
+    if (!system "dpkg-deb --info $fn >/dev/null 2>&1 && dpkg-deb --contents 
$fn >/dev/null 2>&1") {
        return 1;
-    } elsif(!system("dpkg-split --info $fn 2>&1 >/dev/null")) {
+    } elsif (!system "dpkg-split --info $fn >/dev/null 2>&1") {
        return 2;
     }
     return 0;

-- 
Dpkg.Org's dpkg

Reply via email to