Hi Wolfgang, On Fri, Sep 30, 2016 at 12:35:55PM +0200, Wolfgang Schweer wrote: > > commit 478cd4c55e9ab52f28c935db0995392cb77335f9 > > Author: Holger Levsen <[email protected]> > > Date: Sun Sep 11 14:59:13 2016 +0200 > > > > Drop unused bin/debian-edu-current-codename workaround. > > > > Drop bin/debian-edu-current-codename workaround which was only used by > > auto-addfirmware which was replaced by isenkram-autoinstall-firmware > > in debian-edu-config 1.810. > > > Actually 'debian-edu-current-codename' is used also by:
ouch, thanks for catching this!
> sbin/debian-edu-hwsetup
> sbin/debian-edu-ltsp
> sbin/debian-edu-pxeinstall
> share/ltsp/plugins/ltsp-build-client/Debian-custom/000-arch-detection
> share/ltsp/plugins/ltsp-build-client/Debian-custom/000-default-dist
> testsuite/doc
>
> Further investigation showed that 'debian-edu-hwsetup' has been dropped
> from the Makefile some time ago with commit 84e06a5d (but w/o removing
> the file);
looking at 84e06a5d I believe the removal of 'debian-edu-hwsetup' from
the Makefile was a typo or a mistake/premature.
That said, I'm not sure the 3-7 year old work arounds in
'debian-edu-hwsetup' are still worth it…
> a changelog entry is missing, though. 'debian-edu-hwsetup'
> calls isenkram-autoinstall-firmware (among other adjustments) so maybe
> should still be shipped.
… and I believe isenkram is now also called automatically by d-i.
> Not quite sure, but if 'debian-edu-current-codename' is left dropped,
> then maybe replacing each 'debian-edu-current-codename' call with
> 'lsb_release -sc' could make things work again in all cases. If done so,
> 'share/ltsp/plugins/ltsp-build-client/Debian-custom/000-default-dist' is
> no longer of any use and could be dropped.
'000-default-dist' seems to be a reimplementation of
'debian-edu-current-codename'?!?
I guess both 'debian-edu-current-codename' and 'debian-edu-hwsetup'
should go eventually, the question is just whether they can go already
now :-)
--
cheers,
Holger
signature.asc
Description: Digital signature
