On 2 Feb 2003 [EMAIL PROTECTED] wrote: > Has been analyzed. Patch is even in the audit trail, but > seems to have become stuck in gcc's patch acceptance machinery...
The patch isn't even one suitable for review, as it lacks testcases. It is established procedure [0] that patches failing to follow the standards adequately get ignored. Even with them, it just papers over particular problems rather than actually implementing a sensible consistent specification for -Wconversion. [0] This is very bad procedure; ignoring patches rather than explaining what is wrong is far too likely to lose potential contributors. It is, however, what happens; patches not following the standards are more tedious to review than ones following the standards, and even many good patches following the standards get ignored. However, this patch was not ignored; it received several comments on what ought to be done. I expect a patch that followed the GNU and GCC coding standards, including thorough testcases, and implemented the simple specification I gave for -Wconversion (warn for any implicit conversion that may change a value), would get reviewed. -- Joseph S. Myers [EMAIL PROTECTED]