On Oct 08, 2011, at 17:20, Kyle Moffett wrote:
> On Oct 08, 2011, at 14:47, Kyle Moffett wrote:
>> On Oct 08, 2011, at 08:36, Matthias Klose wrote:
>>> except that it does break the native build :-/ pretty please test cross 
>>> patches
>>> with a native build too.
>>> 
>>> with_libgcc is unset with this patch. the stage stuff should go after 
>>> setting
>>> setting with_common_libs etc.
>> 
>> Oops!  You are totally correct.  I thought I'd been so careful to make
>> sure that $(with_libgcc) was still set in the regular path.
>> 
>> How about this alternative patch?  It does not end up moving the stage1/2
>> stuff around, but it does ensure that with_libgcc is always set unless
>> DEB_STAGE=stage1.
>> 
>> This should be much closer to the original code-path for native builds
>> without affecting the altered cross-build state.
>> 
>> NOTE:  I'm just starting my build-tests for this patch, I'll send a
>> separate followup email if both are successful.
> 
> Ok, so I did both native and stage1/stage2 cross builds.
> 
> My cross builds succeeded just fine, but my native builds failed even
> without my patch, with the error described in #644764 [1].
> 
> With that said, my native build with my patch failed while attempting
> to build libgcc, so it seems my new patch is at least partially
> correct there :-D.

I have confirmed that my v3 patch fixes stage1 crossbuilds and still
allows stage2 crossbuilds and native builds to work fine.

Please consider the v3 patch for merging.

Cheers,
Kyle Moffett


--
To UNSUBSCRIBE, email to debian-gcc-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/fd69f521-6796-46f2-a0b4-b791aaf92...@boeing.com

Reply via email to