On 3/26/26 04:13, Andrew Lee wrote:
What? You merged all of them in a few hours
No:
* I opened MR #11 (the main MR) in October and merged it ~3 weeks
ago. (If 5 months is not enough time for people to review then I don't
know what is.)
* I left MR #13 open for a couple of days before I merged it ~3 weeks
ago. It was split off of #11, which had been open for 5 months, so I
figured that gave people plenty of time to opine.
* MR #16 was open for ~2 weeks before I merged it yesterday.
* MR #17 was a minor clarification that didn't really need review.
* MR #18 added a changelog entry, not a policy/procedure change.
just only one team member approved.
MR #11 was thumb-upped by 3 others (in addition to the approval). I
don't know why they didn't just review the MR, but I took that as
general approval.
How many team members should approve changes? I think it's
counterproductive to wait several days/weeks/months for approvals when
it's easy to just revert a change and try again if someone has an objection.
I don't even notice your merge requests exist.
Can we configure Salsa to email debian-go whenever a MR is opened for
the go-team.pages.debian.net project? Should we?
I mentioned MR #11 a few times in the past:
https://lists.debian.org/debian-go/2025/10/msg00022.html
https://lists.debian.org/debian-go/2025/10/msg00035.html
https://lists.debian.org/debian-go/2026/03/msg00005.html
https://lists.debian.org/debian-go/2026/03/msg00007.html
MR #13 once:
https://lists.debian.org/debian-go/2026/03/msg00007.html
And MR #12 (not merged yet) on the topic of circular dependencies a
couple of times:
https://lists.debian.org/debian-go/2026/03/msg00019.html
https://lists.debian.org/debian-go/2026/03/msg00024.html
-Richard
-Andrew
On Thu, Mar 26, 2026 at 7:41 AM Richard Hansen <[email protected]> wrote:
Hi all,
I recently merged some changes to the
<https://go-team.pages.debian.net/packaging.html> page in response to
comments in the thread at
<https://lists.debian.org/debian-go/2025/10/msg00013.html> and in pull
requests to <https://github.com/Debian/dh-make-golang>. For a summary
of the changes, please see
<https://go-team.pages.debian.net/workflow-changes.html#_2026_03_changes>.
tl;dr: Recommend including the major version number:
* in library package names (e.g., golang-example-foo-v2-dev for
example.com/foo/v2)
* in XS-Go-Import-Path
* in installed file locations (e.g.,
/usr/share/gocode/src/example.com/foo/v2)
Also, recommend packaging only one Go module per binary package and only
one binary package per source package to work around some limitations
with dh-make-golang and dh-golang.
dh-make-golang does not follow these best practices when generating a
new package (manual tweaks are often required); I will be working on
that next. Despite this, most packages already conform. I haven't done
an exhaustive survey, but I plan on adding some warnings to
dh-make-golang and/or lintian to make it easier to find packages that
don't follow these best practices. Don't feel obligated to update any
existing packages to conform; if they work now, they should continue to
work with the changes I plan to make.
Also, these are recommendations, not hard rules. Feel free to ignore
them if they are problematic for a package you are working on. Please
let me know if you encounter any such packages; perhaps we can tweak the
best practices to be more broadly useful.
Feel free to tweak or revert my changes if you have concerns.
Thanks,
Richard
