> https://salsa.debian.org/go-team/packages/golang-github-evidlo-syncthingtui

Happy to review and sponsor.

- push upstream branch and upstream/* tag to Salsa so it is possible to
  build it (or adjust watch and/or gbp.conf to specify your intention
  how to find upstream sources)

- Package latest tagged upstream v1.0.0?  Using tags rather than git
  HEAD is better for debian packaging.

- Rename repository to 'syncthingtui'?  There seems to be an empty
  repository with that name already, which could be removed or re-used.

- Upstream source code has no copyright notices, they should be added
  and d/copyright mirror that appropriately.

- Remove debian/gitlab-ci.yml (it is a dummy file now) and
  debian/.gitignore (just confuses tag2upload).

- Use your full name in Uploaders field.

- I enabled Salsa CI:
  
https://salsa.debian.org/go-team/packages/golang-github-evidlo-syncthingtui/-/pipelines/

- You should run lintian on your package, it will reveal several things
  that are easy to fix, in order of suggested fix:

P: syncthingtui source: trailing-whitespace [debian/control:34]
P: syncthingtui source: redundant-priority-optional-field [debian/control:3]
I: syncthingtui source: out-of-date-standards-version 4.7.0 (released 
2024-04-07) (current is 4.7.4)
I: syncthingtui source: older-debian-watch-file-standard 4 [debian/watch]
P: syncthingtui source: package-uses-old-debhelper-compat-version 13
W: syncthingtui: no-manual-page [usr/bin/syncthingtui]
I: syncthingtui source: installable-field-mirrors-source (in section for 
syncthingtui) Section [debian/control:24]
W: syncthingtui: undeclared-elf-prerequisites (libc.so.6) [usr/bin/syncthingtui]

/Simon

Attachment: signature.asc
Description: PGP signature

Reply via email to