Dear Jonas, On Tue, Feb 28, 2012 at 6:46 PM, Jonas Smedegaard <[email protected]> wrote: > Seems you forgot to push the tag created when you added the new upstream > tarball. Please do "git push --tags".
Ah. I forgot it. I pushed it. $ git push --tags --snip-- To ssh://[email protected]/git/collab-maint/pandoc.git * [new tag] upstream/1.9.1.1 -> upstream/1.9.1.1 > Please always check if a package you want to work on contains a > README.source. This one contains one, and one of the things is that I > request that you bump the md5sum when updating upstream source. I can't understand it... Can I write md5sum on the DEB_UPSTREAM_TARBALL_MD5 line by my hand? diff --git a/debian/rules b/debian/rules index f8db39e..88e9def 100755 --- a/debian/rules +++ b/debian/rules @@ -9,7 +9,7 @@ include /usr/share/cdbs/1/class/hlibrary.mk abi = $(DEB_UPSTREAM_TARBALL_VERSION) DEB_UPSTREAM_URL = http://hackage.haskell.org/packages/archive/$(DEB_UPSTREAM_PACKAGE)/$(DEB_UPSTREAM_TARBALL_VERSION) -DEB_UPSTREAM_TARBALL_MD5 = 14ee1d068ca6b6b9f57c12bb45ba42db +DEB_UPSTREAM_TARBALL_MD5 = 8e596946c1c8982c1b5a6bdc4d13b5a0 DEB_COPYRIGHT_CHECK_IGNORE_REGEX = ^.*\.(gif|jpg|odt)|debian/(changelog|copyright(|_hints|_newhints))$ > Great that you improved the watchfile. Remember to mention in changelog > (at least) all user-visible changes. I find your improvement to the > watchfile relevant to mention. I wrote and pushed the message to debian/changes file. >> Sorry. It's my English mistake. >> I kept CDBS style debian/rules. > > No no, don't be sorry. And certainly not for your language skills: I am > non-english too, just happen to live in a country so small that english > influence through media is massive (in Denmark most movies are british > or american and they are subtitled, not dubbed). > > And please read what I wrote: I _encourage_ you to work in the rules > file too! Don't be humble - even if you make mistakes you need not be > sorry, we can just fix it again (and learn from it) :-) Umm...? I am confused... Should I keep your debian/rules style? (a) Or challenge to change it to the style include {debhelper,hlibrary}.mk 2 line only? (b) I think (b) is simple and easy to use. But if (b) blocks our collab-maintenance, I choose (a). Best regards, -- Kiwamu Okabe -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/CAEvX6d=p0j¹[email protected]
