On Thu, Aug 04, 2011 at 07:10:59PM +0200, Guillem Jover wrote:
> I guess I was not clear enough, here what we want to check for is if
> “realpath(path, NULL)” works correctly (notice the NULL argument),
> before POSIX.1-2008 (and newer GNU/* and FreeBSD systems) this was
> undefined behaviour, so even if the system has realpath() it might
> not have what we want from it.

I'd like to suggest an alternative approach would be to test against
PATH_MAX itself (eg, #ifndef PATH_MAX). Arguably a system which provides
neither PATH_MAX not a POSIX.1-2008 realpath() is broken anyway.

On Fri, Aug 05, 2011 at 10:38:05AM +0200, Andrea Bolognani wrote:
> I think Guillem did the right thing here: he explained you exactly why
> your patch is not ready for submission yet, and how you can make it so.

(Agreed.)

-- 
Jeremie Koenig <[email protected]>
http://jk.fr.eu.org


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
Archive: http://lists.debian.org/[email protected]

Reply via email to