Svante Signell, le Tue 11 Feb 2014 18:17:45 +0100, a écrit :
> @@ -531,6 +533,7 @@
>       argv[i++] = level_buf;
>       argv[i++] = NULL;
>  
> +     /* FIXME: since exevp don't return exec_buf is defined static */

There is no need to make it static: execvp does not return simply
because it puts another program in the process. You thus don't even need
to care where the data has been allocated: it'll be completely wiped
once exec succeeds.

Also, I guess you have not really understood what really get static:

static char *foo;

means that it's the foo pointer whose allocation is made static. Not the
data pointed by foo...

Apart from that, it seems fine.

Samuel


-- 
To UNSUBSCRIBE, email to debian-hurd-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: http://lists.debian.org/20140211172636.gs10...@type.bordeaux.inria.fr

Reply via email to