Am Sonntag, den 06.07.2008, 23:12 +0100 schrieb Matthew Johnson: > I've had a quick look at the package and it looks ok, but I don't really > know cdbs, so I'm not that happy pronouncing it good right now. > > I'll hopefully be able to have a better look in the next couple of days, > but if someone happier with cdbs wants to sponsor it in the mean time > then please go ahead.
The CDBS looks fine. IANADD, so I can't sponsor. There are some things I'd like to add (but note the disclaimer above): - I would not rewrite the upstream readme.txt. For the Debian-specific explanations, README.Debian seems appropriate. - There's a mistake in the readme.txt "apt-get graphviz" should be "apt-get install graphviz". - Cosmetics: In orig-tar.sh you could use single quotes in find instead of double quotes to make the regex easier to read. Also, using single quotes around {} prevents problems with spaces in filenames. (The package does not have an of those files, but it won't hurt to use it.) I do not have a possibility to check whether it builds at the moment. Florian, thanks for your work on this! Best regards Manuel
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil