Hi Rémi,
On Mon, Apr 19, 2010 at 4:24 PM, Rémi Debay <remi.de...@acgcenter.com> wrote: > I am looking for a sponsor for my package "acgvision-agent". there are some issues and some of them are not specific to Java: You should file a WNPP bug Cc-ing debian-java@lists.debian.org and close it through debian/changelog. The file debian/conffiles should not be needed. Please remove it. The binary package should not Depend: java-virtual-machine. Please remove it. The binary package should not Depend on java2-runtime only. Please use something like default-jre-headless | java2-runtime-headless - whatever is correct for your package. Please ask if you are not sure. BTW, why do you Build-Depend: openjdk-6-jdk instead of default-jdk? Is openjdk really needed for building? The long description has a typo (communcate), misses a full stop and is very short. Please be more verbose. The copyright file is empty and wouldn't be accepted by the FTP team. Creating /var/log/acgvision in postinst shouldn't be needed but... ... postrm should remove /var/log/acgvision-agent only when purging. But wait: is it /var/log/acgvision or /var/log/acgvision-agent? You have the first variant in debian/dirs. prerm is virtually empty and should be removed. The #DEBHELPER# token is missing in all three scripts. You call ant directly without refering to $JAVA_HOME in debian/rules. That is not good. Please check other packages that Build-Depend java-helper for examples of better packaging practices. I have been told that jsch might be such an example. And don't forget to read the tutorial for java-helper. I cannot build the package because my cowbuilder does not work for unknown reasons and that is why I stop checking your package now, sorry. Cheers, Torsten -- To UNSUBSCRIBE, email to debian-java-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/v2ya90bfcf1004211246l79d9893boe03a03e0298cd...@mail.gmail.com
