Hi Samyak, I got a quick look and technically it's good. I'd suggest some cosmetic changes: - the empty debian/maven.cleanIgnoreRules and debian/maven.publishedRules files can be removed - don't bother packaging the javadoc, it's just a waste of resources - the libjs-jquery dependency can be removed (even if the doc is built) - the indentation of debian/rules is weird, try 'wrap-and-sort -sa' - why repeating twice "imageviewer" in the package name? I suggest renaming to "kazocsaba-imageviewer" for the source package and "libkazocsaba-imageviewer-java" for the binary package. - there is a character encoding issue in debian/copyright on the name of the upstream author
Le 29/05/2020 à 23:33, Samyak Jain a écrit : > Hi, > > I have packaged libimageviewer-image-viewer-java which is acting as a > dependency for a Gradle based Package. Since it is my first attempt to > package a maven based java package. It will be great if someone can > review it. The package builds fines. > > The package exists here[1]. Since I'm a Debian contributor it will be > very helpful if someone can sponsor the package as well. > > I have created an empty repository in the java team which exists here > [2]. I'll push the changes once the package is reviewed. > > > Thanks and regards > Samyak Jain > > [1] https://salsa.debian.org/samyak-jn/libimageviewer-image-viewer-java > [2] https://salsa.debian.org/java-team/libimageviewer-image-viewer-java
