On Wed, Nov 03, 2004 at 05:00:35PM +0100, Roman Zippel wrote: > Hi, > > On Tue, 2 Nov 2004, Horms wrote: > > > Thanks for the patch, though the behaviour of the umask still seems > > rather odd. I would like to offer an updated patch which I believe > > makes the umask behave in the expected way. It also ensures > > that the write_lock bit is read from/written to disk correctly. > > You apply the umask before updating the write bit, which is incorrect.
I tried to account for that, but perhaps I missed. > > @@ -196,6 +197,11 @@ struct inode *hfs_new_inode(struct inode > > HFS_I(inode)->cached_blocks = 0; > > memset(HFS_I(inode)->first_extents, 0, sizeof(hfs_extent_rec)); > > memset(HFS_I(inode)->cached_extents, 0, sizeof(hfs_extent_rec)); > > + inode->i_mode = (mode & ~0777) | (~hsb->s_file_umask & 0777); > > + if (mode & S_IWUSR) > > + inode->i_mode |= S_IWUGO; > > + else > > + inode->i_mode &= ~S_IWUGO; > > } > > insert_inode_hash(inode); > > mark_inode_dirty(inode); > > Thanks, for reminding me to fix hfs_new_inode here, but the above applies. No problem. > > ===== fs/hfs/super.c 1.32 vs edited ===== > > --- 1.32/fs/hfs/super.c 2004-10-26 05:06:47 +09:00 > > +++ edited/fs/hfs/super.c 2004-11-01 20:01:54 +09:00 > > @@ -149,8 +149,8 @@ static int parse_options(char *options, > > /* initialize the sb with defaults */ > > hsb->s_uid = current->uid; > > hsb->s_gid = current->gid; > > - hsb->s_file_umask = 0644; > > - hsb->s_dir_umask = 0755; > > + hsb->s_file_umask = 0111; > > + hsb->s_dir_umask = 0000; > > hsb->s_type = hsb->s_creator = cpu_to_be32(0x3f3f3f3f); /* == '????' */ > > hsb->s_quiet = 0; > > hsb->part = -1; > > This may be closer to the mac default, where everyone can access anything, > but I'd rather keep a safe default. > Below is my updated patch. Thanks, I will give it a spin and get back to you. -- Horms
