Source: nfs-utils
Version: 1:2.9.1-1
Usertags: pidof-without-procps
Dear maintainer(s) of nfs-utils,
it appears that nfs-utils uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.
Please add an explicit dependency on `procps`:
* via the `Depends:` field of all binary packages of nfs-utils
that use `pidof` at runtime;
* via the `Build-Depends:` field of nfs-utils, if `pidof` is
used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
used in autopkgtests.
To prevent any disruption for users of nfs-utils, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.
It is believed that nfs-utils uses `pidof` due to the following
code snippets:
```
path: nfs-utils_1:2.8.6-1/debian/tests/v3-mount
grep "${hello}" /mnt/hello.txt
pidof rpc.statd > /dev/null 2>&1 || {
echo "rpc.statd isn't running after the NVSv3 mount, and it should..."
exit 1
path: nfs-utils_1:2.8.6-1/debian/tests/v3-mount
# stop statd if it's running, because we will check later if it
# was started automatically for the NFSv3 mount as it should
if pidof rpc.statd > /dev/null 2>&1; then
systemctl stop rpc-statd.service > /dev/null 2>&1 || :
pidof rpc.statd > /dev/null 2>&1 && {
```
Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).
Regards,
--
Gioele Barabucci
