From: "Bernhard R. Link" <brl...@debian.org> Date: Sun, 16 Jan 2011 22:09:24 +0100
> * David Miller <da...@davemloft.net> [110116 20:39]: >> From: Richard Mortimer <ri...@oldelvet.org.uk> >> Date: Sun, 16 Jan 2011 14:17:49 +0000 >> >> > I'm wondering if gcc is just getting better at honouring the source >> > code. The DEFINE_EVENT macros in include/trace/ftrace.h have a >> > __aligned__(4) attribute in them. Maybe that should be 8 on sparc64 >> > systems. >> > The aligned 4 seems to be unchanged since include/trace/ftrace.h was >> > created in f42c85e74faa422cf0bc747ed808681145448f88 in April 2009. >> >> That needs to be at least "8" on 64-bit systems. Why is this aligned >> directive there at all? > > Why has this align any effect at all? gcc's documentation says: > > "The `aligned' attribute can only increase the alignment; but you > can decrease it by specifying `packed' as well." > > And as the struct has pointers in it, I'd guess it already had a 64-bit > alignment unless there is some "packed" hidden somewhere. Please do NOT trim the CC: list when replying. :-( Now none of the relevant mailing lists will see what you had to say. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20110116.131701.260092199.da...@davemloft.net
