On Wed, 2011-01-19 at 09:51 +0100, Bastian Blank wrote: > On Sun, Jan 09, 2011 at 06:51:36AM +0000, Ben Hutchings wrote: > > I want to apply this to squeeze. I've seen one too many panics with > > VMware or VirtualBox modules in them, which appear to be worse than > > anything in drivers/staging. > > Don't forget to add it to the bug script. > > > + intree = get_modinfo(sechdrs, infoindex, "intree"); > > + if (!intree) > > + add_taint_module(mod, TAINT_OOT_MODULE); > > Is there a reason for not doing this the following way except that you > copied the staging check?
Exactly. > | if (!get_modinfo(sechdrs, infoindex, "intree")) > | add_taint_module(mod, TAINT_OOT_MODULE); > > The resulting code should be the same[1]. And actually the staging test > looks this way in .37. So, should I go ahead with this (trunk now, maybe squeeze later)? Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/1295844272.12300.8.camel@localhost
