On Tue, 2012-05-08 at 21:16 +0200, Rik Theys wrote:
> Hi,
>
> On Tue, 8 May 2012, Jonathan Nieder wrote:
> >> Hi Trond,
> >>
> >> Can you please comment on wether additional fixes and/or
> >> dependencies are needed to backport the patch below to the Debian
> >> 3.2 kernel?
> >>
> >> The Debian kernel maintainers would prefer some feedback before
> >> applying the fix to their 3.2 kernel.
> >
> > No, the maintainers are just busy. I think everything's in order
> > already.
>
> I asked Ben on IRC and he's still waiting on feedback from Trond first:
>
> [21:04] <rik_> bwh: regarding bug 659111, Jonathan commented that "everything
> is in order". Did I miss a reply from Trond? Will the patch be applied to a
> future kernel update?
> [21:08] <bwh> I don't see any reply from Trond
> [21:09] <bwh> and I really do want to see that
>
> Trond, would you mind commenting on this patch?
So, the "Save owner/group name string" is the most efficient way of
ensuring that the open works as expected, and it should be a fairly
self-contained patch.
There is an alternative solution, which is much shorter (and therefore
appropriate for stable kernels). That is to add a line of the form
nfs_revalidate_inode(server, state->inode);
in _nfs4_do_open() immediately after the "if (opendata->o_arg.open_flags
& O_EXCL) {}" condition. That will cause the NFSv4 client to send an
extra GETATTR if the inode is incomplete.
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
trond.mykleb...@netapp.com
www.netapp.com
