On Sat, 27 Jul 2013, Rodolfo kix Garcia escribió: > On Fri, 26 Jul 2013, Ben Hutchings escribió:
[...] > Hi Ben, > > IMHO we should use the same resume device in all packages. I saw cryptsetup > package is using their own method to get the resume device too. I will notify > it to the cryptsetup team. > > I have some questions before start modify the uswsusp scripts and upload a > new package for testing. > > 1. uswsusp will use the initramfs resume device. So, uswsusp should read the > file included in the initrd image at "conf/conf.d/resume". Is ok? > > 2. If the user select the resume device using boot argument, what should the > uswsusp script do? > > 3. resume will use the device using the argument "-r". This argument will be > used in the uswsusp initrd script, using the file read in the initramfs > resume file (question 1). > > 4. Currently, the initrd image includes two different resume binaries, one in > /bin (I don't know who copies that binary. initramfs-tools?) and other in > /sbin (copied by the uswsusp hook script. Sizes are different. We should use > only one resume binary. > > kix@osaka:~/tmp$ find *bin -name resume -exec ls -l {} \; > -rwxr-xr-x 1 kix kix 2792 jul 27 19:29 bin/resume > -rwxr-xr-x 1 kix kix 40720 jul 27 19:29 sbin/resume > kix@osaka:~/tmp$ > > kix@osaka:~/tmp$ cat debian/initramfs-tools/hooks/uswsusp | grep copy > copy_exec /usr/lib/uswsusp/resume /sbin > kix@osaka:~/tmp$ > > 5. There are two different resume scripts, one included by initramfs-tools > and other by uswsusp. IMO we should use only one: > > kix@osaka:~/tmp/scripts/local-premount$ grep 'bin/resume' * > resume: /bin/resume ${resume} ${resume_offset} > resume: /bin/resume ${resume} > uswsusp:[ -x /sbin/resume ] || exit 0; > uswsusp:/sbin/resume > kix@osaka:~/tmp/scripts/local-premount$ > > 6. What file should read s2disk and s2both to find the resume device when > they save the image? > > 7. The configuration file for uswsusp won't have the resume device. The line > "resume device =" won't exist. So, if the user wants to override the resume > device or select different swap device, what is the better choice? Include > this change in the /etc/uswsusp.conf file? override it in the initramfs > scripts? s2disk and s2both must know the override. > > 8. debian/control file: uswsusp will depends on initramfs-tools? > > 8a. I am not sure about this, because initramfs-tools is required by the > kernel, but there are case that uswsusp doesn't depends on initramfs-tools > and use the resume device in /etc/uswsusp.conf if initramfs-tools is not > installed? Could be initramfs-tools not installed and uswsusp installed? > > I am not sure if I am missing something or if I am in the wrong way. Comments > a very welcome. > > Cheers, > kix I was thinking about that and checking some things. The /bin/resume file is used to boot the resume file created using the kernel (swsusp) and /sbin/resume is used by suspend-utils (uswsusp). I don't know if we can join both methods, using the same resume file. -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130728201610.ga18...@kix.es