Your message dated Wed, 3 Jul 2019 09:57:06 +0000 (UTC)
with message-id <[email protected]>
and subject line Re: Bug#930586: poedit: fix mips64 build with -mxgot instead
of emembed json
has caused the Debian Bug report #930586,
regarding poedit: fix mips64 build with -mxgot instead of emembed json
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
930586: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930586
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:poedit
Version: 2.2.1-2
poedit failed to build on mips64el due to GOT is too small, and so we
should use XGOT.
diff -Nru poedit-2.2.1/debian/rules poedit-2.2.1/debian/rules
--- poedit-2.2.1/debian/rules 2019-01-22 10:52:13.000000000 +0000
+++ poedit-2.2.1/debian/rules 2019-01-22 10:52:13.000000000 +0000
@@ -4,14 +4,14 @@
export LDFLAGS += -Wl,--as-needed
export LDFLAGS += -Wl,-z,relro
+ifneq ($(findstring mips64,$(DEB_HOST_ARCH)),)
+ export CXXFLAGS += -mxgot
+endif
%:
dh $@
override_dh_auto_configure:
-ifeq ($(DEB_HOST_ARCH),mips64el)
- patch -p1 -R < debian/patches/new-json-hpp.patch
-endif
./bootstrap
dh_auto_configure -- --disable-silent-rules --enable-debug
--
YunQiang Su
--- End Message ---
--- Begin Message ---
Hello, sorry for wasting your time in finding a fix...the *exact* (mostly)
same patch has been already part of experimental since 2.2.1-2exp2, uploaded
there because of freeze...
That said, your patch seems to imply that any pattern matching "*mips64*" will
get the additional flag, while my version works onlyfor mips64el.I don't know
if any mips64 will ever be in Debian...Do you think it is worth a change?
BTW I uploaded this fix in unstable yesterday, since the freeze is mostly over
(I mean, changes should now come from s-p-u)
G.
commit 56eb5440abab07fe3229bfc1665fb8f0696e9f3b (tag: debian/2.2.1-2exp2)
Author: Gianfranco Costamagna <[email protected]>
Date: Wed Apr 17 16:49:52 2019 +0200
Drop use of embedded json, use mxgot flag on mips64el instead
thanks <aurel32> for the hint and help!
diff --git a/debian/rules b/debian/rules
index 9dbe509..a6c83c0 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,14 +4,14 @@
export LDFLAGS += -Wl,--as-needed
export LDFLAGS += -Wl,-z,relro
+ifeq ($(DEB_HOST_ARCH),mips64el)
+ export CXXFLAGS += -mxgot
+endif
%:
dh $@
override_dh_auto_configure:
-ifeq ($(DEB_HOST_ARCH),mips64el)
- patch -p1 -R < debian/patches/new-json-hpp.patch
-endif
./bootstrap
dh_auto_configure -- --disable-silent-rules --enable-debug
Il domenica 16 giugno 2019, 06:15:18 CEST, YunQiang Su <[email protected]>
ha scritto:
Package: src:poedit
Version: 2.2.1-2
poedit failed to build on mips64el due to GOT is too small, and so we
should use XGOT.
diff -Nru poedit-2.2.1/debian/rules poedit-2.2.1/debian/rules
--- poedit-2.2.1/debian/rules 2019-01-22 10:52:13.000000000 +0000
+++ poedit-2.2.1/debian/rules 2019-01-22 10:52:13.000000000 +0000
@@ -4,14 +4,14 @@
export LDFLAGS += -Wl,--as-needed
export LDFLAGS += -Wl,-z,relro
+ifneq ($(findstring mips64,$(DEB_HOST_ARCH)),)
+ export CXXFLAGS += -mxgot
+endif
%:
dh $@
override_dh_auto_configure:
-ifeq ($(DEB_HOST_ARCH),mips64el)
- patch -p1 -R < debian/patches/new-json-hpp.patch
-endif
./bootstrap
dh_auto_configure -- --disable-silent-rules --enable-debug
--
YunQiang Su
--- End Message ---
_______________________________________________
Debian-l10n-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-l10n-devel