Please find, for review, the debconf templates and packages descriptions for 
the ooniprobe source package.

This review will last from Tuesday, May 12, 2015 to Friday, May 22, 2015.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:
--- ooniprobe.old/debian/templates      2015-05-04 15:01:02.594609802 +0200
+++ ooniprobe/debian/templates  2015-05-12 07:24:43.064269766 +0200
@@ -1,22 +1,22 @@
 Template: ooniprobe/run-cronjob
 Type: boolean
 Default: false
-_Description: Would you like to run a daily network test?
+_Description: Run ooniprobe daily?

We usually avoid constructions such as "Would you like".....so just
simplify the question to the vital minimum.....but include a
"ooniprobe" keyword: this is not a random "network test".


  ooniprobe can be configured to run a set of basic network tests on a daily
  basis. This will test the currently network for signs of surveillance and
  censorship, and send the results to the main OONI collector through the Tor
  network.
  .
- Choosing to run a network test daily will insert a cron job entry. This job
- will be run as the Debian-ooni user.
+ If you choose this option, a daily test will be added as a cron job run
+ as the "Debian-ooni" user.

Use our standard formulation "If you choose this option". Probably to
improve in order to avoid the double "as".. Justin?

  .
- WARNING: Running OONI may be against the terms of service of your ISP or
- legally questionable in your country. By running OONI you will connect to web
- services which may be banned, and use web censorship circumvention methods 
such
- as Tor. The OONI project will publish data submitted by probes, possibly
+ You should be aware that running OONI may break the terms of service
+ of your ISP or be legally questionable in your country. The software
+ will identify which web services are banned and uses web censorship
+ circumvention methods such as Tor. The OONI project will publish data 
submitted by probes, possibly
  including your IP address or other identifying information. In addition, your
  use of OONI will be clear to anybody who has access to your computer, and to
- anybody who can monitor your internet connection (such as your employer, ISP 
or
+ anybody who can monitor your Internet connection (such as your employer, ISP 
or
  government).
  .
  For more information on the risks associated with running ooniprobe, see

Avoid the "WARNING" : we alsays propose dropping such "WARNING" and
"NOTE" and just be factual.

Slight rewording.....


-- 

Template: ooniprobe/run-cronjob
Type: boolean
Default: false
_Description: Run ooniprobe daily?
 ooniprobe can be configured to run a set of basic network tests on a daily
 basis. This will test the currently network for signs of surveillance and
 censorship, and send the results to the main OONI collector through the Tor
 network.
 .
 If you choose this option, a daily test will be added as a cron job run
 as the "Debian-ooni" user.
 .
 You should be aware that running OONI may break the terms of service
 of your ISP or be legally questionable in your country. The software
 will identify which web services are banned and uses web censorship
 circumvention methods such as Tor. The OONI project will publish data 
submitted by probes, possibly
 including your IP address or other identifying information. In addition, your
 use of OONI will be clear to anybody who has access to your computer, and to
 anybody who can monitor your Internet connection (such as your employer, ISP or
 government).
 .
 For more information on the risks associated with running ooniprobe, see
 /usr/share/doc/ooniprobe/RISKS.
--- ooniprobe.old/debian/templates      2015-05-04 15:01:02.594609802 +0200
+++ ooniprobe/debian/templates  2015-05-12 07:26:49.195109516 +0200
@@ -1,22 +1,22 @@
 Template: ooniprobe/run-cronjob
 Type: boolean
 Default: false
-_Description: Would you like to run a daily network test?
+_Description: Run ooniprobe daily?
  ooniprobe can be configured to run a set of basic network tests on a daily
  basis. This will test the currently network for signs of surveillance and
  censorship, and send the results to the main OONI collector through the Tor
  network.
  .
- Choosing to run a network test daily will insert a cron job entry. This job
- will be run as the Debian-ooni user.
+ If you choose this option, a daily test will be added as a cron job run
+ as the "Debian-ooni" user.
  .
- WARNING: Running OONI may be against the terms of service of your ISP or
- legally questionable in your country. By running OONI you will connect to web
- services which may be banned, and use web censorship circumvention methods 
such
- as Tor. The OONI project will publish data submitted by probes, possibly
+ You should be aware that running OONI may break the terms of service
+ of your ISP or be legally questionable in your country. The software
+ will identify which web services are banned and uses web censorship
+ circumvention methods such as Tor. The OONI project will publish data 
submitted by probes, possibly
  including your IP address or other identifying information. In addition, your
  use of OONI will be clear to anybody who has access to your computer, and to
- anybody who can monitor your internet connection (such as your employer, ISP 
or
+ anybody who can monitor your Internet connection (such as your employer, ISP 
or
  government).
  .
  For more information on the risks associated with running ooniprobe, see
--- ooniprobe.old/debian/changelog      2015-05-04 15:01:02.594609802 +0200
+++ ooniprobe/debian/changelog  2015-05-04 15:19:40.715780696 +0200
@@ -1,3 +1,11 @@
+ooniprobe (1.3.1-2) UNRELEASED; urgency=low
+
+  * Debconf templates and debian/control reviewed by the debian-l10n-
+    english team as part of the Smith review project. Closes: #784241
+  * [Debconf translation updates]
+
+ -- Christian Perrier <bubu...@debian.org>  Mon, 04 May 2015 15:19:40 +0200
+
 ooniprobe (1.3.1-1) unstable; urgency=low
 
   [ Jérémy Bobbio ]
Source: ooniprobe
Maintainer: Jérémy Bobbio <lu...@debian.org>
Uploaders: Iain R. Learmonth <i...@fsfe.org>
Section: net
Priority: extra
Build-Depends: debhelper (>= 9),
               dh-python,
               po-debconf,
               python-all (>= 2.6.6-3~),
               python-docutils (>= 0.9.1),
               python-geoip (>= 0.2.5),
               python-ipaddr (>= 2.1.10),
               python-mock,
               python-openssl (>= 0.13),
               python-scapy (>= 2.2),
               python-setuptools,
               python-twisted (>= 12.2.0),
               python-txsocksx,
               python-txtorcon (>= 0.7),
               python-yaml (>= 3.10),
               python-zope.interface (>= 3.6),
               tor
Standards-Version: 3.9.6
X-Python-Version: >= 2.7
Vcs-Git: git://anonscm.debian.org/collab-maint/ooniprobe.git
Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/ooniprobe.git
Homepage: https://ooni.torproject.org/

Package: ooniprobe
Architecture: all
Depends: ${misc:Depends}, ${python:Depends},
               adduser,
               tor,
               geoip-database
Recommends: python-dumbnet, python-pypcap
Suggests: geoip-database-contrib, obfsproxy
Description: probe for the Open Observatory of Network Interference (OONI)
 OONI, the Open Observatory of Network Interference, is a global observation
 network which aims is to collect high quality data using open methodologies
 and free software to share observations and data about the various types,
 methods, and amounts of network tampering in the world.
 .
 ooniprobe is a program to probe a network and collect data for the OONI
 project. It will test the current network for signs of surveillance and
 censorship.

Attachment: signature.asc
Description: Digital signature

Reply via email to