Your message dated Tue, 04 Mar 2008 02:47:03 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#467642: fixed in lintian 1.23.46
has caused the Debian Bug report #467642,
regarding new check for unneeded control scripts
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
467642: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=467642
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: lintian
Version: 1.23.45
Severity: wishlist

Attached patch should enable lintian to warn against unneeded control
files. It adds a warning against (semantically) empty control files
and against some ancient checks. (I don't think package need still check
in preinst if the version of dpkg running is newer than from 1999).

Hochachtungsvoll,
        Bernhard R. Link
diff -rup lintian-1.23.45/checks/control-files lintian-1.23.45patched/checks/control-files
--- lintian-1.23.45/checks/control-files	2008-01-03 03:03:56.000000000 +0100
+++ lintian-1.23.45patched/checks/control-files	2008-02-26 17:45:18.000000000 +0100
@@ -103,12 +103,44 @@ while (<IN>) {
 	tag "control-file-has-bad-owner", "$file $owner != root/root";
     }
 
+    # actual content?
+    open(IN2, '<', "control/$file") or
+        fail("cannot open maintainer script control/$file for reading: $!");
+    my $has_content = 0;
+    while (<IN2>) {
+        next if m/^\#/;
+        next if m/^[[:space:]]*$/;
+	$has_content = 1;
+
+        if (m/dpkg[[:space:]]*--assert-support-predepends/) {
+            tag "ancient-predepends-check", "$file";
+        }
+        if (m/dpkg[[:space:]]*--assert-working-epoch/) {
+            tag "ancient-epoch-check", "$file";
+        }
+        if (m/dpkg[[:space:]]*--assert-long-filenames/) {
+            tag "ancient-long-filenames-check", "$file";
+        }
+        if (m/dpkg[[:space:]]*--assert-multi-conrep/) {
+            tag "ancient-multi-conrep-check", "$file";
+        }
+    }
+    close(IN2);
+    unless ($has_content) {
+        tag "empty-control-file", "$file";
+    }
+
 # for other maintainer scripts checks, see the scripts check
 }
 close IN;
 
 } # </run>
 
+sub check_control_script {
+  my ($script) = @_;
+
+}
+
 1;
 
 # vim: syntax=perl sw=4 ts=8
diff -rup lintian-1.23.45/checks/control-files.desc lintian-1.23.45patched/checks/control-files.desc
--- lintian-1.23.45/checks/control-files.desc	2008-01-03 02:59:17.000000000 +0100
+++ lintian-1.23.45patched/checks/control-files.desc	2008-02-26 17:47:23.000000000 +0100
@@ -26,3 +26,28 @@ Info: The postinst, postrm, preinst, and
 Tag: control-file-has-bad-owner
 Type: error
 Info: All control files should be owned by root/root.
+
+Tag: empty-control-file
+Type: warning
+Info: The package contains a control file with only comments and empty
+ lines. This should be removed instead.
+
+Tag: ancient-predepends-check
+Type: warning
+Info: The package calls dpkg --assert-support-predepends in a control
+ file. This always returns true since dpkg 1.1.0 released Feb 1996.
+
+Tag: ancient-epoch-check
+Type: warning
+Info: The package calls dpkg --assert-working-epoch in a control
+ file. This always returns true since dpkg 1.4.0.7 released Jan 1997.
+
+Tag: ancient-long-filenames-check
+Type: warning
+Info: The package calls dpkg --assert-long-filenames in a control
+ file. This always return true since dpkg 1.4.1.17 released Oct 1999.
+
+Tag: ancient-multi-conrep-check
+Type: warning
+Info: The package calls dpkg --assert-multi-conrep in a control
+ file. This always returns true since dpkg 1.4.1.19 released Oct 1999.

--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 1.23.46

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive:

lintian_1.23.46.dsc
  to pool/main/l/lintian/lintian_1.23.46.dsc
lintian_1.23.46.tar.gz
  to pool/main/l/lintian/lintian_1.23.46.tar.gz
lintian_1.23.46_all.deb
  to pool/main/l/lintian/lintian_1.23.46_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Russ Allbery <[EMAIL PROTECTED]> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 03 Mar 2008 18:21:32 -0800
Source: lintian
Binary: lintian
Architecture: source all
Version: 1.23.46
Distribution: unstable
Urgency: low
Maintainer: Debian Lintian Maintainers <[EMAIL PROTECTED]>
Changed-By: Russ Allbery <[EMAIL PROTECTED]>
Description: 
 lintian    - Debian package checker
Closes: 410042 421011 452215 463474 464992 465132 465192 465258 466501 466617 
466665 466701 466714 466979 467019 467425 467642 468362 468370 468759 468927 
469024 469106 469222
Changes: 
 lintian (1.23.46) unstable; urgency=low
 .
   The "five Lintian committers!" release.
 .
   * checks/binaries:
     + [RA] Anchor file matches for Perl libraries and debugging symbols so
       as to not match partial paths.  Based on a patch from Niko Tyni.
       (Closes: #466501)
     + [RA] Also check for make -i when checking if errors from make clean or
       distclean are ignored.  Thanks, Jörg Sommer.  (Closes: #469024)
   * checks/changelog-file:
     + [RA] Adjust for the extra space added by Parse::DebianChangelog when
       checking line length.  Thanks, Robert Millan.  (Closes: #467019)
   * checks/common_data.pm:
     + [RA] Accept (and ignore for now) the new Checksums-Sha1,
       Checksums-Sha256, and Checksums-Md5 fields in source packages.
       Thanks, Raphael Hertzog.  (Closes: #466979)
   * checks/control-file:
     + [RA] Skip empty dependencies for stronger-dependency-implies-weaker.
   * checks/control-files{.desc,}:
     + [FL] Warn about empty control files. I can't see any use for
       them. Exclude udebs though, since they might differ there.
   * checks/copyright-file{.desc,}:
     + [RA] Tests for copyright notices must be case-insensitive.  Patch
       from Chris Lamb.  (Closes: #464992)
     + [RA] When looking for cases where Copyright is separated from a year
       by a newline, also allow (C) before or after the newline.  Thanks,
       Michael Meskes.  (Closes: #465258)
     + [RA] Further explain why lintian looks for a valid copyright notice.
       (Closes: #466714)
     + [RA] Suggest an override if only the Debian packaging or some other
       part of the package not linked with OpenSSL is covered by the GPL.
       Thanks, Andrew Pollock.  (Closes: #469106)
   * checks/cruft{.desc,}:
     + [FL] Add hg to the list of <vcs>-control-dir tags.
     + [RA] In the long description of outdated-autotools-helper-file,
       point to autotool-dev's documentation.  (Closes: #465132)
     + [RA] Remove now-unnecessary workarounds for calling File::Find with
       symlink starting directory.
   * checks/debian-readme{.desc,}:
     + [RA] Warn of references to /usr/doc in README.Debian.  Thanks,
       Guillem Jover.  (Closes: #465192)
   * checks/files{.desc,}:
     + [FL,RA] Merge all the tags for vcs ignore files, inventory files,
       and vcs control dirs. Since the explanations don't actually differ,
       different tags make no sense. While at it, add the mercurial
       equivalents as well and update some of the tag descriptions. Partly
       based on a patch by Chris Lamb.
   * checks/md5sums{.desc,}:
     + [FL] Remove tag md5sums-control-file-is-empty in favour of
       a more general tag in control-files.
   * checks/manpages.desc:
     + [RA] Mention in binary-without-manpage that if the man pages are
       provided by another package on which this package depends, a lintian
       override is appropriate.
   * checks/menu-format:
     + [RA] When the menu or desktop file invokes a quoted command via an
       su program, don't try to check whether the command is in the
       package.  Thanks, Paul Wise.  (Closes: #466665)
   * checks/menus{,desc}:
     + [RA] Check that doc-base files are encoded in UTF-8.  Thanks, Robert
       Luberda.  (Closes: #468759)
     + [RA] Check doc-base sections against the new canonical list.
       Thanks, Robert Luberda.  (Closes: #463474)
   * check/patch-systems:
     + [HE] Warn if the .diff.gz contains changes while the package uses
       a patch system. (Closes: #452215)
   * checks/scripts{.desc,}:
     + [FL] Warn if a maintainer script is a valid shell script but
       doesn't seem to have any actual code.  Based on an idea
       by Justin Pryzby.  (Closes: #410042)
     + [RA] Update regexes based on checkbashisms to remove additional
       false positives and add additional checks.  Thanks, Adam D. Barratt.
     + [RA] Add kaptain.  Thanks, Tobias Toedter.  (Closes: #466701)
     + [RA] Allow zsh-beta as an alternative to zsh.  Thanks, Joost van
       Baal.  (Closes: #468362)
     + [RA] Add yorick.  Thanks, Thibaut Paumard.  (Closes: #468370)
     + [RA] Add warnings for dpkg --assert* flags for features that have
       been guaranteed for nearly a decade.  Thanks, Bernhard R. Link.
       (Closes: #467642)
   * checks/shared-libs{,desc}:
     + [RA] Rename sharedobject-in-library-directory-not-actually-a-shlib
       to sharedobject-in-library-directory-missing-soname for clarity.
       Thanks, Peter Eisentraut.  (Closes: #467425)
 .
   * data/doc-base/sections:
     + [RA] New file listing known doc-base sections.
 .
   * debian/dirs:
     + [RA] Install the base directory for the Lintian root here.
   * debian/rules:
     + [RA] Redo the installation rules to support arbitrary nesting under
       the copied directories.  As a side effect, install
       lib/Tags/ColonSeparated.pm, unbreaking the experimental
       colon-separated output format.
 .
   * frontend/lintian:
     + [CW] Make the presence of an Ubuntu release name in the version number
       trigger the Ubuntu distribution field checks.
     + [RA] Fix option parsing bug leading lintian to incorrectly reject -a
       or -p without a package.
 .
   * lib/Dep.pm:
     + [RA] Skip empty dependencies, avoiding false positives for
       stronger-dependency-implies-weaker.  Patch from Adam D. Barratt.
       (Closes: #469222)
   * lib/Lintian/Data.pm:
     + [RA] New module for loading and querying lists of keywords.
   * lib/Read_pkglists.pm:
     + [RA] Extract Uploaders from the source package list.
   * lib/Spelling.pm:
     + [RA] Add another spelling correction.
     + [RA] Merriam-Webster and the OED have both given up on publically
       vs. publicly, so we should as well.  (Closes: #466617)
 .
   * reporting/html_reports:
     + [RA] Load the correct configuration file.
     + [RA] Include packages for which one is an uploader in one's
       maintainer page, marked accordingly.  (Closes: #421011)
   * reporting/templates/*:
     + [TK] Correct Lintian maintainers address in page footers.
   * reporting/templates/maintainer.html:
     + [RA] Include packages for which the maintainer is an uploader.
 .
   * unpack/list-srcpkg:
     + [RA] Include Uploaders in the package list.
   * unpack/unpack-srcpkg-l2:
     + [RA] Don't rely on the output format of dpkg-source to learn the
       source directory and create a symlink.  Instead, tell dpkg-source to
       unpack the source directly into the unpacked directory.  Discard
       output of dpkg-source to allow for the current version, which prints
       things even with -q (fixed in later versions).  Thanks, Raphael
       Hertzog.  (Closes: #468927)
Files: 
 403e0452a59c1ff32b2f9140c625ec19 904 devel optional lintian_1.23.46.dsc
 5452c83a18e27584ad026b6dc4e8787a 395985 devel optional lintian_1.23.46.tar.gz
 1b6cd600f83ebf4fd97e07845efa43c2 328062 devel optional lintian_1.23.46_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHzLQs+YXjQAr8dHYRAnPkAKCopY4X5qkpIBolLn9KYZxJc5VfUgCbBkTv
dJeSxNp7SYHQDJ/YVYhix0M=
=PMlY
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to