"Adam D. Barratt" <[EMAIL PROTECTED]> writes: > On Thu, 2008-03-13 at 00:01 +0100, [EMAIL PROTECTED] wrote: > [...] >> Log: >> * lib/Spelling.pm: >> + [RA] Avoid Perl warnings when called with an uninitialized value. > [...] >> Modified: trunk/lib/Spelling.pm >> =================================================================== >> --- trunk/lib/Spelling.pm 2008-03-12 17:52:44 UTC (rev 1263) >> +++ trunk/lib/Spelling.pm 2008-03-12 23:01:25 UTC (rev 1264) >> @@ -398,6 +398,7 @@ >> # not defined, it will be omitted. >> sub spelling_check { >> my ($tag, $text, $filename) = @_; >> + next unless $text; > > This change appears to generate a new set of warnings however; it should > be s/next/return/: > > Exiting subroutine via next at /home/adam/lintian/lib/Spelling.pm line 401. > Exiting subroutine via next at /home/adam/lintian/lib/Spelling.pm line 401. > Exiting eval via next at /home/adam/lintian/lib/Spelling.pm line 401. > Exiting subroutine via next at /home/adam/lintian/lib/Spelling.pm line 401. > > (Spotted via having forgotten to unset LINTIANROOT after looking at > #469222 a couple of weeks ago :-)
Good catch. Thanks. -- Russ Allbery ([EMAIL PROTECTED]) <http://www.eyrie.org/~eagle/> -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]