On Sun, 2011-06-05 at 13:11 +0200, Niels Thykier wrote: > I am not really sure what to say about the detection strings, except I > feel they seem very generic (but I could be wrong)[1]. With > embedded-library being an auto-reject tag now (about 45 minutes ago), I > think we have to be more careful about false-positives here. > > ~Niels > > [1] I do not know how common "This app uses Xiph.Org libtheora for > feature XYZ" etc. strings are in applications or libraries.
Agreed about false positives. Good to hear it was added to ftp-master autorejects, hopefully that is in the overridable set? Since probably a fair few embedded code copies are modified versions. Before submitting it I searched the lintian laboratory strings files for the detection strings I suggested and verified the resulting list (see below) actually contained embedded code copies using buildd logs. In any case these libraries have very few strings in them and the strings I suggested are the most specific ones I could find. pabs@bellini:/srv/lintian.debian.org/laboratory$ grep -r "Xiph.Org libtheora" binary/*/strings binary/icedove/strings/usr/lib/icedove/components/libgklayout.so:(Xiph.Org libtheora 1.1 20090822 (Thusnelda) binary/iceowl/strings/usr/lib/iceowl/iceowl-bin:(Xiph.Org libtheora 1.1 20090822 (Thusnelda) binary/libtheora0/strings/usr/lib/libtheora.so.0.3.10:(Xiph.Org libtheora 1.1 20090822 (Thusnelda) binary/libtheora0/strings/usr/lib/libtheoraenc.so.1.1.2:Xiph.Org libtheora 1.1 20090822 (Thusnelda) binary/libtheora0/strings/usr/lib/libtheoradec.so.1.1.4:(Xiph.Org libtheora 1.1 20090822 (Thusnelda) pabs@bellini:/srv/lintian.debian.org/laboratory$ grep -r 'Missing GL version' binary/*/strings binary/blender/strings/usr/bin/blender:Missing GL version binary/blender/strings/usr/bin/blenderplayer:Missing GL version binary/gem/strings/usr/lib/pd/extra/Gem/Gem.pd_linux:Missing GL version binary/k3d/strings/usr/lib/libk3dsdk-glew.so.1:Missing GL version binary/libcegui-mk2-1/strings/usr/lib/libCEGUIOpenGLRenderer.so.0.1.0:Missing GL version binary/libglew1.5/strings/usr/lib/libGLEW.so.1.5.8:Missing GL version binary/libglewmx1.5/strings/usr/lib/libGLEWmx.so.1.5.8:Missing GL version binary/libogre-1.7.3/strings/usr/lib/OGRE/RenderSystem_GL.so:Missing GL version binary/libogremain-1.7.1/strings/usr/lib/OGRE/RenderSystem_GL.so:Missing GL version binary/scorched3d/strings/usr/games/scorched3dc:Missing GL version pabs@bellini:/srv/lintian.debian.org/laboratory$ grep -r "Extension name exceeds 1023 characters." binary/*/strings binary/libglee0d1/strings/usr/lib/libglee.so.0d1.0:Extension name exceeds 1023 characters. binary/qcake/strings/usr/lib/qcake/qcakeplayer_qt4:Extension name exceeds 1023 characters. binary/qcake/strings/usr/lib/qcake/qcake_qt4:Extension name exceeds 1023 characters. binary/stellarium/strings/usr/bin/stellarium:Extension name exceeds 1023 characters. -- bye, pabs http://wiki.debian.org/PaulWise
signature.asc
Description: This is a digitally signed message part