Hi Jakub pointed out that a some of our source files have inconsistent. He also produced the attached document that visualize the different indentation styles in our code ("Tttttttt" is one tab and "s" is a space).
So would anyone object if I sed s/\t/ /g'ed our code (with manual fixup where needed). It could (and probably will) give issues applying any existing patches (on the BTS). ~Niels
checks/fields: ss 1 ssss 46 sssss 8 Tttttttt 167 ssssssss 1 Ttttttttss 1 Ttttttttssss 26 TtttttttTttttttt 128 TtttttttTtttttttsss 1 TtttttttTtttttttssss 25 TtttttttTtttttttsssss 6 TtttttttTtttttttsssssss 1 TtttttttTtttttttTttttttt 72 TtttttttTtttttttTtttttttssss 14 TtttttttTtttttttTtttttttTttttttt 65 TtttttttTtttttttTtttttttTttttttts 1 TtttttttTtttttttTtttttttTtttttttssss 31 TtttttttTtttttttTtttttttTtttttttsssss 1 TtttttttTtttttttTtttttttTtttttttsssssss 1 TtttttttTtttttttTtttttttTtttttttTttttttt 33 TtttttttTtttttttTtttttttTtttttttTtttttttssss 16 TtttttttTtttttttTtttttttTtttttttTtttttttTttttttt 7 TtttttttTtttttttTtttttttTtttttttTtttttttTtttttttTttttttt 1 checks/conffiles: ssss 9 Tttttttt 17 Ttttttttssss 6 TtttttttTttttttt 1 checks/description: ssss 64 ssssssss 1 Tttttttt 38 Ttttttttsss 2 Ttttttttssss 8 TtttttttTttttttt 1 TtttttttTtttttttsss 1 sssssssssssssssssssssssss 2 checks/patch-systems: Tttttttt 44 Ttttttttss 1 TtttttttTttttttt 27 TtttttttTtttttttssss 6 TtttttttTtttttttsssss 1 TtttttttTtttttttTttttttt 16 TtttttttTtttttttTtttttttTttttttt 19 TtttttttTtttttttTtttttttTtttttttTttttttt 29 TtttttttTtttttttTtttttttTtttttttTtttttttssss 2 TtttttttTtttttttTtttttttTtttttttTtttttttTttttttt 29 TtttttttTtttttttTtttttttTtttttttTtttttttTtttttttTttttttt 16 checks/shared-libs: ssss 125 ssssss 1 sssssss 7 ssssssss 8 Tttttttt 117 ssssssssssss 5 Ttttttttssss 105 Ttttttttsssss 2 ssssssssssssssss 6 TtttttttTttttttt 46 sTtttttttTttttttt 1 TtttttttTtttttttssss 14 ssssssssssssssssssss 1 TtttttttTtttttttTttttttt 10 TtttttttTtttttttTttttttts 1 TtttttttTtttttttTtttttttssss 4 TtttttttTtttttttTtttttttTttttttt 1 checks/debian-readme: ssss 7 sssss 2 ssssssss 3 ssssssssssss 1 checks/java: ssss 40 ssssssss 12 Tttttttt 10 ssssssssssss 8 Ttttttttssss 2 ssssssssssssssss 3 TtttttttTttttttt 2 TtttttttTtttttttssss 4 TtttttttTtttttttTttttttt 2 ssssssssssssssssssssssss 9 ssssssssssssssssssssssssssss 1 checks/infofiles: ssss 29 ssssssss 1 Tttttttt 18 Ttttttttssss 14 TtttttttTttttttt 4 TtttttttTtttttttssss 1 TtttttttTtttttttTtttttttss 1 checks/menu-format: ssss 202 ssssss 7 sssssss 183 ssssssss 43 Tttttttt 95 Ttttttttsss 7 sssssssssss 1 Ttttttttssss 40 ssssssssssss 26 Ttttttttsssss 7 Ttttttttssssss 3 Ttttttttsssssss 1 TtttttttTttttttt 64 ssssssssssssssss 17 TtttttttTtttttttssss 2 ssssssssssssssssssss 1 sssssssssssssssssssss 1 TtttttttTtttttttsssss 2 TtttttttTtttttttTtttttttTtttttttssssss 1 TtttttttTtttttttTtttttttTtttttttTtttttttss 1 checks/debian-source-dir: ssss 15 ssssssss 3 Tttttttt 6 Ttttttttssss 3 ssssssssssss 1 TtttttttTttttttt 6 TtttttttTtttttttssss 2 checks/circular-deps: ssss 42 ssssssss 20 ssssssssssss 13 checks/nmu: ssss 2 Tttttttt 30 TtttttttTttttttt 10 TtttttttTtttttttssss 2 TtttttttTtttttttTttttttt 1 checks/watch-file: ss 1 ssss 21 ssssssss 50 ssssssssssss 26 ssssssssssssssss 5 ssssssssssssssssssss 4 checks/filename-length: ssss 18 ssssssss 5 checks/init.d: ssss 83 sssss 10 ssssssss 3 Tttttttt 94 Ttttttttssss 54 ssssssssssss 1 TtttttttTttttttt 32 TtttttttTtttttttssss 38 TtttttttTtttttttTttttttt 3 checks/source-copyright: ssss 55 Tttttttt 44 Ttttttttssss 38 TtttttttTttttttt 14 TtttttttTtttttttssss 5 checks/control-file: ssss 3 Tttttttt 45 Ttttttttssss 1 TtttttttTttttttt 65 Ttttttttssssssss 1 TtttttttTtttttttssss 4 TtttttttTtttttttsssssss 1 TtttttttTtttttttTttttttt 28 TtttttttTtttttttTtttttttss 3 TtttttttTtttttttTtttttttssss 7 TtttttttTtttttttTtttttttsssss 1 TtttttttTtttttttTtttttttsssssss 5 TtttttttTtttttttTtttttttTttttttt 12 TtttttttTtttttttTtttttttTtttttttss 1 TtttttttTtttttttTtttttttTtttttttssss 1 checks/changes-file: ssss 24 Tttttttt 24 ssssssss 1 Ttttttttssss 16 TtttttttTttttttt 6 TtttttttTttttttts 1 TtttttttTtttttttssss 2 TtttttttTtttttttsssss 8 TtttttttTtttttttTttttttt 3 checks/po-debconf: ssss 7 Tttttttt 26 ssssssss 14 Ttttttttssss 2 ssssssssssssssss 5 TtttttttTttttttt 18 ssssssssssssssssTttttttt 1 TtttttttTtttttttTttttttt 8 sssssssssssssssssssssssssss 1 TtttttttTtttttttTtttttttTttttttt 6 TtttttttTtttttttTtttttttTtttttttTttttttt 9 checks/ocaml: ssss 48 ssssssss 35 ssssssssssss 14 checks/huge-usr-share: ssss 6 ssssssss 1 Tttttttt 1 checks/debhelper: ssss 69 ssssssss 5 Tttttttt 92 Ttttttttsss 1 Ttttttttssss 38 TtttttttTttttttt 18 TtttttttTtttttttssss 3 TtttttttTtttttttsssss 1 TtttttttTtttttttTttttttt 1 checks/duplicate-files: ssss 18 ssssssss 5 checks/control-files: ssss 26 Tttttttt 6 Ttttttttssss 5 checks/manpages: ssss 48 sssssss 1 ssssssss 1 Tttttttt 75 Tttttttts 9 Ttttttttssss 87 ssssTttttttt 3 Ttttttttsssss 1 Ttttttttsssssss 1 TtttttttTttttttt 50 ssssssssssssssss 3 TtttttttTttttttts 2 TtttttttTtttttttssss 17 ssssssssssssssssssss 5 TtttttttTtttttttsssss 1 TtttttttTtttttttTttttttt 5 TtttttttTtttttttTtttttttss 1 TtttttttTtttttttTtttttttssss 4 TtttttttTtttttttTtttttttssssss 2 TtttttttTtttttttTtttttttsssssss 1 TtttttttTtttttttTtttttttTttttttt 4 checks/version-substvars: Tttttttt 7 TtttttttTttttttt 16 TtttttttTtttttttsssssss 1 TtttttttTtttttttTttttttt 8 TtttttttTtttttttTtttttttTttttttt 7 TtttttttTtttttttTtttttttTtttttttTttttttt 6 checks/binaries: ssss 82 ssssssss 4 Tttttttt 133 Ttttttttssss 53 ssssssssssss 10 TtttttttTttttttt 18 ssssssssssssssss 1 TtttttttTtttttttTtttttttsss 1 TtttttttTtttttttTtttttttssss 2 TtttttttTtttttttTtttttttsssss 1 checks/common_data.pm: ss 1 sss 1 checks/menus: ssss 142 Tttttttt 78 ssssssss 72 Ttttttttssss 83 ssssssssssss 54 Ttttttttsssssss 1 TtttttttTttttttt 23 ssssssssssssssss 18 TtttttttTtttttttssss 3 ssssssssssssssssssss 8 sssssssssssssssssssssssssss 2 TtttttttTtttttttTtttttttsssss 2 TtttttttTtttttttTtttttttTttttttts 2 sssssssssssssssssssssssssssssssss 2 ssssssssssssssssssssssssssssssssssss 1 TtttttttTtttttttTtttttttTtttttttsssss 2 ssssssssssssssssssssssssssssssssssssssss 1 checks/copyright-file: ssss 83 ssssss 1 Tttttttt 53 sssssssss 1 Ttttttttssss 15 ssssTttttttt 12 Ttttttttsssss 4 checks/deb-format: ssss 26 ssssssss 23 ssssssssssss 18 sssssssssssssss 3 ssssssssssssssss 1 checks/standards-version: ssss 32 ssssssss 15 ssssssssssss 6 ssssssssssssssss 2 checks/debconf: ssss 86 sssssss 8 Tttttttt 97 ssssssss 10 Ttttttttssss 78 ssssssssssss 6 Ttttttttssssss 1 TtttttttTttttttt 43 ssssssssssssssss 2 Ttttttttssssssss 14 ssssssssssssssssss 1 Ttttttttsssssssssss 1 TtttttttTtttttttssss 15 Ttttttttssssssssssss 1 TtttttttTtttttttssssssss 1 TtttttttTtttttttTttttttt 6 TtttttttTtttttttTtttttttssss 2 checks/scripts: ssss 249 sssss 75 ssssssss 10 Tttttttt 168 Ttttttttssss 154 ssssssssssss 20 Ttttttttsssss 1 sssssssssssss 1 TtttttttTttttttt 158 ssssssssssssssss 2 TtttttttTttttttts 4 TtttttttTtttttttss 14 TtttttttTtttttttssss 53 ssssssssssssssssssssss 1 TtttttttTtttttttTttttttt 19 TtttttttTtttttttTttttttts 1 TtttttttTtttttttTtttttttssss 14 checks/files: ssss 269 sssss 1 sssssss 4 Tttttttt 362 ssssssss 10 Ttttttttss 1 Ttttttttsss 2 sssssssssss 3 ssssssssssss 14 Ttttttttssss 244 Ttttttttsssss 1 sssssssssssssss 1 Ttttttttsssssss 9 ssssssssssssssss 2 TtttttttTttttttt 156 TtttttttssssTttttttt 2 TtttttttTtttttttssss 58 ssssssssssssssssssss 1 TtttttttTtttttttTttttttt 11 TtttttttTtttttttssssTttttttt 1 TtttttttTtttttttTtttttttssss 2 TtttttttTtttttttTtttttttsssssss 3 TtttttttTtttttttTtttttttTttttttt 2 TtttttttTtttttttssssssssssssssss 1 TtttttttTtttttttTtttttttTttttttts 2 TtttttttTtttttttTtttttttTtttttttssss 6 checks/changelog-file: ssss 99 ssssss 3 Tttttttt 87 ssssssss 13 ssssTttttttt 3 Ttttttttssss 41 ssssssssssss 7 Ttttttttssssss 2 TtttttttTttttttt 18 ssssssssssssssss 1 TtttttttTtttttttssss 3 ssssssssssssssssssss 1 TtttttttTtttttttsssssss 1 TtttttttTtttttttssssssss 1 TtttttttTtttttttTttttttt 1 checks/symlinks: ssss 11 ssssssss 20 Tttttttt 2 ssssssssssss 4 checks/rules: ssss 72 sssss 36 ssssssss 49 Tttttttt 6 ssssssssssss 35 Ttttttttssss 1 ssssTttttttt 3 ssssssssssssssss 40 ssssssssssssssssssss 20 ssssssssssssssssssssssss 13 ssssssssssssssssssssssssssss 4 checks/md5sums: ssss 29 Tttttttt 13 ssssssss 1 Ttttttttssss 2 checks/cruft: ssss 68 sssss 16 ssssssss 57 Tttttttt 3 ssssssssssss 35 sssssssssssssss 1 ssssssssssssssss 18 ssssssssssssssssssss 7 lib/Checker.pm: Tttttttt 11 Ttttttttssss 3 lib/Lab.pm: ssss 85 ssssssss 28 Tttttttt 25 ssssssssssss 4 ssssTttttttt 1 Ttttttttssss 6 ssssssssssssssss 1 TtttttttTttttttt 16 TtttttttTtttttttss 3 TtttttttTtttttttsssssss 4 TtttttttTtttttttTttttttt 6 ssssssssssssssssssssssssssssssss 1 lib/Util.pm: ssss 126 Tttttttt 85 Ttttttttss 3 Ttttttttssss 38 TtttttttTttttttt 10 TtttttttTtttttttTttttttt 2 lib/Lintian/Tag/Info.pm: ssss 95 ssssssss 46 ssssssssssss 18 sssssssssssss 5 ssssssssssssssss 1 lib/Lintian/Tag/Override.pm: s 7 ssss 22 sssss 1 ssssssss 22 ssssssssssss 7 lib/Lintian/Data.pm: ssss 17 ssssssss 9 ssssssssssss 5 ssssssssssssssss 10 ssssssssssssssssssss 3 lib/Lintian/Internal/FrontendUtil.pm: ssss 35 Tttttttt 12 ssssssss 3 lib/Lintian/Check.pm: ssss 64 ssssssss 19 Tttttttt 12 ssssssssssss 17 Ttttttttssss 8 ssssssssssssssss 6 TtttttttTttttttt 4 ssssssssssssssssssss 1 lib/Lintian/Command/Simple.pm: ssss 73 ssssssss 8 Tttttttt 78 ssssssssssss 5 Ttttttttssss 16 TtttttttTttttttt 5 TtttttttTtttttttTttttttt 1 lib/Lintian/Collect/Source.pm: ssss 95 ssssssss 51 ssssssssssss 15 Ttttttttssss 1 sssssssssssssss 1 ssssssssssssssss 2 sssssssssssssssssss 2 lib/Lintian/Collect/Binary.pm: s 1 ssss 89 ssssssss 36 Tttttttt 10 ssssssssssss 37 Ttttttttssss 6 sssssssssssssss 1 ssssssssssssssss 21 TtttttttTttttttt 6 sssssssssssssssssss 2 TtttttttTtttttttssss 3 ssssssssssssssssssss 1 lib/Lintian/Collect/Package.pm: s 9 ss 1 ssss 58 ssssssss 32 Tttttttt 7 ssssssssssss 16 ssssssssssssssss 1 lib/Lintian/Collect/Changes.pm: ssss 19 Tttttttt 14 ssssssss 2 Ttttttttssss 8 TtttttttTttttttt 1 lib/Lintian/Tags.pm: ssss 187 ssssssss 102 ssssssssssss 47 ssssssssssssssss 28 ssssssssssssssssss 3 ssssssssssssssssssss 6 lib/Lintian/DepMap/Properties.pm: ssss 35 Tttttttt 6 lib/Lintian/Relation/Version.pm: ssss 39 sssssssssssssssssssss 1 lib/Lintian/ProcessablePool.pm: s 7 ssss 71 ssssssss 31 ssssssssssss 8 sssssssssssss 1 ssssssssssssssss 6 lib/Lintian/Output.pm: s 1 ssss 81 Tttttttt 17 Ttttttttssss 10 TtttttttTttttttt 1 TtttttttTttttttts 1 TtttttttTtttttttss 2 TtttttttTtttttttsssss 1 TtttttttTtttttttsssssss 1 lib/Lintian/Output/ColonSeparated.pm: ssss 19 Tttttttt 14 ssssssss 1 lib/Lintian/Output/XML.pm: ssss 25 ssssssss 5 sssssssssssssssss 6 lib/Lintian/Output/LetterQualifier.pm: ssss 43 Tttttttt 6 ssssssss 37 lib/Lintian/Profile.pm: s 8 ssss 114 sssss 1 ssssssss 46 Tttttttt 6 ssssssssssss 21 Ttttttttssss 1 ssssssssssssssss 6 ssssssssssssssssssss 1 lib/Lintian/Collect.pm: ssss 30 ssssssss 12 Tttttttt 2 ssssssssssss 8 ssssssssssssssss 2 lib/Lintian/Command.pm: ssss 50 Tttttttt 43 Ttttttttssss 33 Ttttttttsssss 1 TtttttttTttttttt 6 TtttttttTttttttts 1 TtttttttTtttttttsssssss 3 TtttttttTtttttttTtttttttsss 2 lib/Lintian/Relation.pm: ssss 122 ssssssss 138 sssssssss 11 ssssssssss 7 ssssssssssss 90 ssssssssssssssss 20 ssssssssssssssssssss 9 ssssssssssssssssssssssss 2 lib/Lintian/Processable.pm: s 6 ssss 33 ssssssss 37 ssssssssssss 10 lib/Lintian/ProcessableGroup.pm: s 6 ssss 57 sssss 1 ssssssss 58 Tttttttt 1 ssssssssssss 13 lib/Lintian/DepMap.pm: ssss 193 Tttttttt 49 Ttttttttssss 15 TtttttttTttttttt 3 TtttttttTtttttttssss 5 TtttttttTtttttttTtttttttsssss 1 lib/Read_pkglists.pm: ss 28 ssss 18 ssssss 6 sssssss 20 ssssssssss 2 lib/Text_utils.pm: ssss 39 Tttttttt 55 Ttttttttssss 28 TtttttttTttttttt 21 lib/Lab/Package.pm: s 7 ssss 109 ssssss 1 ssssssss 1 Tttttttt 57 Ttttttttssss 31 TtttttttTttttttt 1