Hi Niels,
On 24 August 2015 at 09:00, Niels Thykier <ni...@thykier.net> wrote:
> Hi Raphael,
>
> I noticed that you added the embedded-lib check for freetype. The
> discriminator we currently use is a public function, which means even
> correct shared use may cause an auto-reject tag (see below).
>
> * Are you aware of another discriminator we can use instead, which is
> not a part of the public API?
After digging in freetype's source code I found one that appears to be
safer and safe in general.
Attached patch makes lintian look for that other string. I will commit
it sometime during the week (I don't have access to my ssh key atm).
Apologies for responding until now.
Cheers,
--
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net
From 98bda78e8afd03a7c25dc9a758fe957f13b5d340 Mon Sep 17 00:00:00 2001
From: Raphael Geissert <geiss...@debian.org>
Date: Tue, 15 Sep 2015 12:55:13 +0200
Subject: [PATCH] Correct the detection of freetype embedders (Closes: #756722)
Even though we now match on the name of a font, all the uses I could
find of it in the archive were copies of FreeType. Moreover, matching
on the name with the question mark should really limit the number of
false positives.
---
data/binaries/embedded-libs | 2 +-
debian/changelog | 3 +++
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/data/binaries/embedded-libs b/data/binaries/embedded-libs
index 0f979e2..2918446 100644
--- a/data/binaries/embedded-libs
+++ b/data/binaries/embedded-libs
@@ -39,7 +39,7 @@ bzip2 ||(?m)^This is a bug in bzip2
curl ||A libcurl function was given a bad argument
expat ||(?m)^requested feature requires XML_DTD support in Expat
file ||(?m)^could not find any (?:valid )?magic files
-freetype ||FT_Get_CID_Is_Internally_CID_Keyed
+freetype ||HuaTianSongTi[?]
ftgl ||FTGlyphContainer
gl2ps ||\(C\) 1999-2009 C\. Geuzaine
glee ||Extension name exceeds 1023 characters\.
diff --git a/debian/changelog b/debian/changelog
index dace2e9..bc1a8b0 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -8,6 +8,9 @@ lintian (2.5.38) UNRELEASED; urgency=medium
* checks/obsolete-sites.pm:
+ [AB] Stop at <>, $, or " when emitting URLs as tag parameter.
+ * data/binaries/embedded-libs:
+ + [RG] Use a different string to detect the copies of freetype
+ (Closes: #756722)
* data/obsolete-sites/obsolete-sites:
+ [AB] Add patch by Hideki Yamane to add sourceforge.jp (Closes:
#798736)
--
1.7.2.5
