This is an automated email from the git hooks/post-receive script. nthykier pushed a commit to branch master in repository lintian.
commit 59e37beaf9494a2eeada7e88c66c77f3e1dee82d Author: Niels Thykier <ni...@thykier.net> Date: Sun Jul 31 16:07:49 2016 +0000 c/group-checks: Drop "lower priorties" check Signed-off-by: Niels Thykier <ni...@thykier.net> --- checks/group-checks.desc | 12 ---------- checks/group-checks.pm | 23 ------------------ debian/changelog | 4 ++++ .../debian/debian/control.in | 27 ---------------------- .../debian/debian/rules | 9 -------- .../debian/some-doc.txt | 1 - t/tests/group-checks-wrong-priorities/desc | 5 ---- t/tests/group-checks-wrong-priorities/tags | 1 - t/tests/legacy-libbaz/tags | 1 - 9 files changed, 4 insertions(+), 79 deletions(-) diff --git a/checks/group-checks.desc b/checks/group-checks.desc index 219feda..5346574 100644 --- a/checks/group-checks.desc +++ b/checks/group-checks.desc @@ -23,18 +23,6 @@ Info: The listed packages from the same source circularly depend different source packages is beyond the scope of Lintian. Ref: policy 7.2 -Tag: package-depends-on-lower-priority-package -Severity: normal -Certainty: certain -Ref: policy 2.5, https://qa.debian.org/debcheck.php -Info: The package depends on a package with lower priority than - itself. - . - Note: This check is limited to packages created from the same source - package. A full check of all dependencies built from different - source packages is beyond the scope of Lintian. The depcheck service - can do this. - Tag: binaries-have-file-conflict Severity: normal Certainty: possible diff --git a/checks/group-checks.pm b/checks/group-checks.pm index 2810976..b9fd621 100644 --- a/checks/group-checks.pm +++ b/checks/group-checks.pm @@ -54,7 +54,6 @@ sub run { my $pname = $proc->pkg_name; push @nodes, $pname; $edges{$pname} = [map { $_->pkg_name } @$deps]; - _check_priorities($proc, $deps); _check_multiarch($proc, $deps); } } @@ -74,28 +73,6 @@ sub run { return; } -# Check that $proc has a priority that is less than or equal to that -# of its dependencies (Policy ยง2.5) -sub _check_priorities { - my ($proc, $deps) = @_; - my $priority = $proc->info->field('priority'); - my $pkg_name = $proc->pkg_name; - if ($priority) { - my $prival = $KNOWN_PRIOS->value($priority); - foreach my $dep (@$deps) { - my $dpri = $dep->info->field('priority') // ''; - my $dprival = $KNOWN_PRIOS->value($dpri); - # Ignore packages without priorities - we have a separate - # check for that. - next unless $dprival; - tag 'package-depends-on-lower-priority-package', - "$pkg_name:$priority", 'depends on', $dep->pkg_name . ":$dpri" - unless $prival <= $dprival; - } - } - return; -} - sub _check_file_overlap { my (@procs) = @_; # Sort them for stable output diff --git a/debian/changelog b/debian/changelog index 59ad040..c9fe366 100644 --- a/debian/changelog +++ b/debian/changelog @@ -13,6 +13,10 @@ lintian (2.5.46) UNRELEASED; urgency=medium (Closes: #828773) * checks/files.desc: + [JW] Fix typos. + * checks/group-checks.{desc,pm}: + + [NT] Drop "lower priorities" check as the general conseus seems to + be that priorties changes are mostly busy work. Thanks to Dominic + Hargreaves for the report. (Closes: #823326) * checks/infofiles.desc: + [JW] Fix typo. * checks/java.pm: diff --git a/t/tests/group-checks-wrong-priorities/debian/debian/control.in b/t/tests/group-checks-wrong-priorities/debian/debian/control.in deleted file mode 100644 index a56bb8c..0000000 --- a/t/tests/group-checks-wrong-priorities/debian/debian/control.in +++ /dev/null @@ -1,27 +0,0 @@ -Source: {$source} -Priority: extra -Section: {$section} -Maintainer: {$author} -Standards-Version: {$standards_version} -Build-Depends: debhelper (>= 9) - -Package: pkg-optional -Architecture: all -Priority: optional -Depends: $\{misc:Depends\}, pkg-extra -Description: {$description} - pkg-optional - This is a test package designed to exercise some feature or tag of - Lintian. It is part of the Lintian test suite and may do very odd - things. It should not be installed like a regular package. - . - optional. - -Package: pkg-extra -Architecture: all -Depends: $\{misc:Depends\} -Description: {$description} - pkg-extra - This is a test package designed to exercise some feature or tag of - Lintian. It is part of the Lintian test suite and may do very odd - things. It should not be installed like a regular package. - . - extra. diff --git a/t/tests/group-checks-wrong-priorities/debian/debian/rules b/t/tests/group-checks-wrong-priorities/debian/debian/rules deleted file mode 100644 index 644131e..0000000 --- a/t/tests/group-checks-wrong-priorities/debian/debian/rules +++ /dev/null @@ -1,9 +0,0 @@ -#!/usr/bin/make -f - -%: - dh $@ - -override_dh_installdocs: - for P in $$(dh_listpackages) ; do \ - dh_installdocs -p$$P some-doc.txt || exit 1 ;\ - done diff --git a/t/tests/group-checks-wrong-priorities/debian/some-doc.txt b/t/tests/group-checks-wrong-priorities/debian/some-doc.txt deleted file mode 100644 index e845566..0000000 --- a/t/tests/group-checks-wrong-priorities/debian/some-doc.txt +++ /dev/null @@ -1 +0,0 @@ -README diff --git a/t/tests/group-checks-wrong-priorities/desc b/t/tests/group-checks-wrong-priorities/desc deleted file mode 100644 index 00dcd22..0000000 --- a/t/tests/group-checks-wrong-priorities/desc +++ /dev/null @@ -1,5 +0,0 @@ -Testname: group-checks-wrong-priorities -Sequence: 6000 -Version: 1.0 -Description: Test for priority issues -Test-For: package-depends-on-lower-priority-package diff --git a/t/tests/group-checks-wrong-priorities/tags b/t/tests/group-checks-wrong-priorities/tags deleted file mode 100644 index fc975c9..0000000 --- a/t/tests/group-checks-wrong-priorities/tags +++ /dev/null @@ -1 +0,0 @@ -W: group-checks-wrong-priorities source: package-depends-on-lower-priority-package pkg-optional:optional depends on pkg-extra:extra diff --git a/t/tests/legacy-libbaz/tags b/t/tests/legacy-libbaz/tags index 42f44bc..3010321 100644 --- a/t/tests/legacy-libbaz/tags +++ b/t/tests/legacy-libbaz/tags @@ -44,7 +44,6 @@ W: libbaz source: debhelper-but-no-misc-depends libbaz2 W: libbaz source: debhelper-but-no-misc-depends libbaz2-dbg W: libbaz source: debhelper-but-no-misc-depends libbaz2-dev W: libbaz source: native-package-with-dash-version -W: libbaz source: package-depends-on-lower-priority-package libbaz2-dbg:optional depends on libbaz2:extra W: libbaz source: source-nmu-has-incorrect-version-number 1-1 W: libbaz source: substvar-source-version-is-deprecated libbaz2-dev W: libbaz1-dev: wrong-section-according-to-package-name libbaz1-dev => libdevel -- Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git