[Git][lintian/lintian][master] 2 commits: Read test diff as bytes for immediate printing.

[Felix Lechner]

Felix Lechner pushed to branch master at lintian / lintian


Commits:
95897129 by Felix Lechner at 2020-06-05T07:38:49-07:00
Read test diff as bytes for immediate printing.

May otherwise cause wide character errors, particularly on Ansgar's
test cases for 'colorful' maintainer addresses, which will become test
cases in the near future:

    Wide character in print at t/bin/runtests line 483.

It would be silly to parse the diff as UTF-8 and convert it right back
for printing.

Gbp-Dch: ignore

- - - - -
ad4c446e by Felix Lechner at 2020-06-05T07:44:40-07:00
Add two test cases from Ansgar's 'colorful' test package. (See: 
#962277)

Below is the original *.dsc that gave rise to both cases. Perhaps
Salsa will show the escape sequences?

The Maintainer address contains ANSI escape sequences for many colors,
plus blinking.

The Uploaders address includes a UTF-8 RIGHT-TO-LEFT OVERRIDE.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 3.0 (native)
Source: colorful
Binary: colorful
Architecture: all
Version: 1
Maintainer: Colorful 
<"colorful"@43-1.org>
Uploaders: Ansgar <"‮ansgar"@43-1.org>
Standards-Version: 4.5.0
Build-Depends: debhelper-compat (= 13)
Package-List:
 colorful deb misc optional arch=all
Checksums-Sha1:
 43d4b3c075021d4b289affe136fcd212fb9f5da6 1412 colorful_1.tar.xz
Checksums-Sha256:
 ca5bad845ba84bab1d84f8e9b4792f7a92cbe1be3cf8b010389bde82f63c10b5 1412 
colorful_1.tar.xz
Files:
 7fa97791d08c7ae2764e75ee1e86824a 1412 colorful_1.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJTBAEBCgA9FiEEDJOr3FWozOtfziCXgqh1rnceDD4FAl7aCoQfHGFuc2dhci5i
dXJjaGFyZHRAdHUtZHJlc2Rlbi5kZQAKCRCCqHWudx4MPhMQD/9jPgtHHQRFApjI
3aZT6fYQbXu223+C6cjkSEIy2xKjaxm0DxqfZamSyhkjNBSql9V21o5bzh5jiB0T
L3XVfAIRS5MLkUR2EsPYHKsBYpCVU5qESdBl2xN+WDvSAp95rydOBZo7u12N1YUo
HzJqG3anpYg/73Vy8z1IV9iuZHYnFlh7OhDMd64H/bHeOtuNfKquOQ3dFd25JEFj
b8m5wOjbLfPZSq7hX2btSqd+jjk8wAjUL4Cnh5yyOilVV4zk5cvCqpvF+rlmVtxr
JhIlSiqYKSAQfePg00JLZTAMtuECy/bR8cq3Zm/9iiOE81F3mXFVWfP+bmhVUbkG
OC1kZwYFxsgadX3uJlDPVC9DEn3xnWvFQdTM18GDfxhncapavi/dap+EybInGVAQ
g+EwmCCR1VDzAN5xzgUyGSNwpylv1uTQ/YUJT+0yL3H8L5nwWmqTW4tlOsQ/GRQI
hHx52JqjRKH52Krn2Q05dggi2jcTt3wRO7ClaW80q1wrFo1mutZa6TnJ3RAdAg4x
QAHQA/KQjuYApKYQzYL4b/jfttVbq3LSeV3bAQu5jU8aqA6AYTotKe1NIjg8bQ9+
Vg3KIfpiFXVGwRwkxKevq36rJ4T0bunvDUWJUSn+vprkmClN8XmpbijaqO1o0uu5
6OBj9C5IFp2fpdVPrfDSZvpBWwrW/g==
=2ls4
-----END PGP SIGNATURE-----

- - - - -


7 changed files:

- t/bin/runtests
- + t/tags/checks/fields/maintainer/colorful/build-spec/fill-values
- + t/tags/checks/fields/maintainer/colorful/eval/desc
- + t/tags/checks/fields/maintainer/colorful/eval/tags
- + 
t/tags/checks/fields/maintainer/right-to-left-override/build-spec/fill-values
- + t/tags/checks/fields/maintainer/right-to-left-override/eval/desc
- + t/tags/checks/fields/maintainer/right-to-left-override/eval/tags


Changes:

=====================================
t/bin/runtests
=====================================
@@ -479,7 +479,7 @@ if (-t STDOUT && !$unattended) {
             next
               unless -r $diffpath;
 
-            my $diff = path($diffpath)->slurp_utf8;
+            my $diff = path($diffpath)->slurp;
             print $diff;
 
         } elsif ($testcase->{match_strategy} eq 'literal') {


=====================================
t/tags/checks/fields/maintainer/colorful/build-spec/fill-values
=====================================
@@ -0,0 +1,4 @@
+Skeleton: upload-native
+Testname: colorful
+Author: Colorful 
<"colorful"@43-1.org>
+Description: Colorful maintainer from Ansgar's 'colorful' test package (false 
positive)


=====================================
t/tags/checks/fields/maintainer/colorful/eval/desc
=====================================
@@ -0,0 +1,3 @@
+Testname: colorful
+Check: fields/maintainer
+Reference: Bug#962277


=====================================
t/tags/checks/fields/maintainer/colorful/eval/tags
=====================================
@@ -0,0 +1,2 @@
+colorful (source): maintainer Colorful 
<"colorful"@43-1.org>
+colorful (binary): maintainer Colorful 
<"colorful"@43-1.org>


=====================================
t/tags/checks/fields/maintainer/right-to-left-override/build-spec/fill-values
=====================================
@@ -0,0 +1,4 @@
+Skeleton: upload-native
+Testname: right-to-left-override
+Author: Ansgar <"‮ansgar"@43-1.org>
+Description: Maintainer with UTF-8 RIGHT-TO-LEFT OVERRIDE from Ansgar's 
'colorful' test package (false positive)


=====================================
t/tags/checks/fields/maintainer/right-to-left-override/eval/desc
=====================================
@@ -0,0 +1,3 @@
+Testname: right-to-left-override
+Check: fields/maintainer
+Reference: Bug#962277


=====================================
t/tags/checks/fields/maintainer/right-to-left-override/eval/tags
=====================================
@@ -0,0 +1,4 @@
+right-to-left-override (source): maintainer-address-malformed ‮ans...@43-1.org
+right-to-left-override (source): maintainer Ansgar <‮ans...@43-1.org>
+right-to-left-override (binary): maintainer-address-malformed 
‮ans...@43-1.org
+right-to-left-override (binary): maintainer Ansgar <‮ans...@43-1.org>



View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/compare/3caf8aeb507eb3b106af2b9f4380a90c7509acd9...ad4c446e2b042cb4beb27b81b670d8760895b5f7

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/compare/3caf8aeb507eb3b106af2b9f4380a90c7509acd9...ad4c446e2b042cb4beb27b81b670d8760895b5f7
You're receiving this email because of your account on salsa.debian.org.