Felix Lechner pushed to branch master at lintian / lintian
Commits: ac114aa6 by Felix Lechner at 2022-01-13T05:34:48-08:00 Recognize pybuild-plugin-pyproject as a valid prerequisite for the python3 Debhelper plugin. (Closes: #1003668) The prerequisite handling in Lintian for Python is more complicated than any other Debhelper build system or sequence. [1] It is presently unclear that it must be so. The current code adds another level of exemption to code that already provides for manual adjustment [2] of an automated procedure. [3] A review of the code by the Python team would be appreciated. As can be seen below, The offending hint in poetry is now gone. Thanks to Andrius Merkys for bringing the matter to our attention! [1] https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Check/Debhelper.pm#L806-817 [2] https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Check/Debhelper.pm#L120-121 [3] https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Check/Debhelper.pm#L338-341 * * * ➤ bin/lintian -X cruft /mirror/debian/pool/main/p/poetry/poetry_1.1.12+dfsg-1.dsc P: poetry source: update-debian-copyright 2020 vs 2021 [debian/copyright:11] X: poetry source: debian-watch-does-not-check-gpg-signature [debian/watch] X: poetry source: prefer-uscan-symlink filenamemangle s/.+\/v?(\d\S+)\.tar\.gz/$1\.tar\.gz/ [debian/watch:7] X: poetry source: upstream-metadata-file-is-missing - - - - - 2 changed files: - lib/Lintian/Check/Debhelper.pm - t/recipes/checks/debhelper/debhelper-dh-with-python3/eval/hints Changes: ===================================== lib/Lintian/Check/Debhelper.pm ===================================== @@ -805,7 +805,7 @@ sub source { # As a special case, the python3 addon needs a dependency on # dh-python unless the -dev packages are used. - my $python_source = 'dh-python:any'; + my $python_source = 'dh-python:any | pybuild-plugin-pyproject:any'; $self->pointed_hint('missing-build-dependency-for-dh-addon', $drules->pointer,$addon, "(does not satisfy $python_source)") ===================================== t/recipes/checks/debhelper/debhelper-dh-with-python3/eval/hints ===================================== @@ -1,4 +1,4 @@ -debhelper-dh-with-python3 (source): missing-build-dependency-for-dh-addon python3 (does not satisfy dh-python:any) [debian/rules] +debhelper-dh-with-python3 (source): missing-build-dependency-for-dh-addon python3 (does not satisfy dh-python:any | pybuild-plugin-pyproject:any) [debian/rules] debhelper-dh-with-python3 (source): debian-build-system dh [debian/rules] debhelper-dh-with-python3 (source): debhelper-compat-virtual-relation 13 [debian/control] debhelper-dh-with-python3 (source): debhelper-compat-level 13 View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/ac114aa61d6f7b78ccf3b25f4ecc15d588d44f2f -- View it on GitLab: https://salsa.debian.org/lintian/lintian/-/commit/ac114aa61d6f7b78ccf3b25f4ecc15d588d44f2f You're receiving this email because of your account on salsa.debian.org.
