[Git][lintian/lintian][master] Emit error when a trailing comma is present in the Maintainer field

[@pollo]

Louis-Philippe Véronneau pushed to branch master at lintian / lintian


Commits:
8ec38122 by Maytham Alsudany at 2025-03-19T22:20:43+00:00
Emit error when a trailing comma is present in the Maintainer field

Closes: #1089649

- - - - -


5 changed files:

- lib/Lintian/Check/Fields/Maintainer.pm
- + 
t/recipes/checks/fields/maintainer/fields-trailing-comma-in-maintainer-field/build-spec/fill-values
- + 
t/recipes/checks/fields/maintainer/fields-trailing-comma-in-maintainer-field/eval/desc
- + 
t/recipes/checks/fields/maintainer/fields-trailing-comma-in-maintainer-field/eval/hints
- + tags/t/trailing-comma-in-maintainer-field.tag


Changes:

=====================================
lib/Lintian/Check/Fields/Maintainer.pm
=====================================
@@ -48,6 +48,9 @@ sub source {
     $self->hint('no-human-maintainers')
       if $is_list && !$self->processable->fields->declares('Uploaders');
 
+    $self->hint('trailing-comma-in-maintainer-field', $maintainer)
+      if $maintainer =~ /,$/;
+
     return;
 }
 


=====================================
t/recipes/checks/fields/maintainer/fields-trailing-comma-in-maintainer-field/build-spec/fill-values
=====================================
@@ -0,0 +1,4 @@
+Skeleton: upload-native
+Testname: fields-trailing-comma-in-maintainer-field
+Description: Checks for a trailing comma in the Maintainer field
+Author: Maytham Alsudany <maytha8the...@gmail.com>,


=====================================
t/recipes/checks/fields/maintainer/fields-trailing-comma-in-maintainer-field/eval/desc
=====================================
@@ -0,0 +1,2 @@
+Testname: fields-trailing-comma-in-maintainer-field
+Check: fields/maintainer


=====================================
t/recipes/checks/fields/maintainer/fields-trailing-comma-in-maintainer-field/eval/hints
=====================================
@@ -0,0 +1 @@
+fields-trailing-comma-in-maintainer-field (source): 
trailing-comma-in-maintainer-field Maytham Alsudany <maytha8the...@gmail.com>,


=====================================
tags/t/trailing-comma-in-maintainer-field.tag
=====================================
@@ -0,0 +1,7 @@
+Tag: trailing-comma-in-maintainer-field
+Severity: error
+Check: fields/maintainer
+Explanation: The Maintainer field contains a trailing comma, which is not
+ permitted as there can only be one maintainer. This breaks the parsing of some
+ tools such as the Debian Package Tracker.
+See-Also: debian-policy 5.6.2, Bug#1089649



View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/8ec3812246d66912760bc6adb1c5fa75616b8288

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/8ec3812246d66912760bc6adb1c5fa75616b8288
You're receiving this email because of your account on salsa.debian.org.