I coded that part and some basic test seems to imply its wrong as you have noticed. It should be in binary_iso which it's the one that I use.
Here there is: https://salsa.debian.org/live-team/live-build/-/blob/d6096622f9f7f9e2e1c8b01b4769c9d08487688e/scripts/build/binary_iso#L109-171 So I suggest you to implement the fix according to that code so that the code is homogenous. Thank you! P.S.: Offotpic. I am unable to implement that while loop with IFS being set to comma, whatever I try. :( El mar., 10 mar. 2020 a las 19:52, <jnq...@gmail.com> escribió: > On Tue, 2020-03-10 at 15:38 +0000, jnq...@gmail.com wrote: > > another todo list item of mine that I have not gotten around to yet, > > that perhaps someone could find time to assist with is that I've > > encountered the following error with generation of the source disc: > > > > ``` > > E: Unable to find a source package for syslinux,grub-efi > > dpkg-query: no packages found matching syslinux,grub-efi > > ``` > > > > note that I'm using git master and various local branches built on > > that; I do not yet know whether or not this occurs with the latest > > released version (haven't found time to check yet). > > > > obviously it seems to be treating "syslinux,grub-efi" as a single > > package name which is wrong. this string originates from > > LB_BOOTLOADERS. > > > > the code that should be handling this in source_debian looks to be > > the > > following: > > ``` > > echo "${LB_BOOTLOADERS}" | \ > > while IFS="," read -r BOOTLOADER > > do > > echo "${BOOTLOADER}" >> source-selection.txt > > done > > ``` > > > > which is correctly specifying a comma as the separator, so if this is > > where the problem originates, I don't know why... > > there is definitely something wrong here, and it seems also in similar > code in binary_hdd... > > ``` > LB_BOOTLOADERS="syslinux,grub-efi" > echo "${LB_BOOTLOADERS}" | while IFS="," read -r BOOTLOADER; do > echo "bootloader: ${BOOTLOADER}" > done > ``` > this code always fails to split the comma separated string... > > i don't know why it will not work, but i've got an alternate to replace > it with in the form: > > ``` > for BOOTLOADER in $(echo "${LB_BOOTLOADERS}" | tr "," "\n"); do > echo "bootloader: ${BOOTLOADER}" > done > ``` > > MR to follow > > -- Support free software. Donate to Super Grub Disk. Apoya el software libre. Dona a Super Grub Disk. https://www.supergrubdisk.org/donate/
