Hello Otto, On Sat, Oct 03, 2026 at 05:28:15PM +0200, Sylvain Beucler wrote: > On 01/10/2026 16:39, Otto Kekalainen wrote: > > I have prepared the update in the title at > > https://salsa.debian.org/mariadb-team/mariadb-server/-/merge_requests/180 > > > > This is however a rather complex package that required significant > > work. I was wondering if anyone on the LTS team wants to collaborate > > by reviewing the MR, re-reviewing my fixes, and once final version has > > been uploaded, issue the DLA? > > I can review this, over the next few days :)
Overall this looks, but I have some suggestions. - In addition to your changes, this updat also brings https://salsa.debian.org/mariadb-team/mariadb-server/-/merge_requests/171 In general I'd be against adding substantial changes in the Debian build process (in particular changing the debhelper target version) mid-release. However as you clarified in the changelog, this is a counter-fix to other breaking changes that had high security impact. I'm not sure what brought this issue in the first place, but in general I'd recommend staying on the same debian/* build system during a stable release. Similarly, upstream changes to systemd start-up files on a stable branch are surprising, and a hazard :/ It's less a matter of stability than a matter of behavior change mid-release. Maybe this particular issue is worth adding an autopkgtest, to check consistency between the configuration and the actual opened ports (per netstat). - "Salsa CI: Clean away Bullseye tests due to broken security updates" I was hoping to suggest reverting this and temporarily use the ELTS repository until bullseye is properly archived at archive.d.o. However there are upcoming plans to make ELTS access-restricted, so.. I won't. Just a suggestion: maybe we can keep these tests against: http://snapshot.debian.org/archive/debian-security/20260903T220410Z - "Add Lintian override for new upstream version test file)" +shell-script-fails-syntax-check [usr/share/mysql/mysql-test/lib/generate-ssl-certs.sh] I'd suggest replacing /bin/sh -> /bin/bash in the script header (and possibly forward to upstream), which also fixes the issue. - "Skip tests main.mysql_client_test* as they require Internet access" At first glance, I'd suggest keeping a way to run tests that need Internet through autopkgtest with 'needs-internet'. With this change, tests are blocked both in buildds and CI environments. - 1 small test issue on 32-bit, the MAX value is different: https://debusine.debian.net/debian/developers/artifact/4955230/ https://debusine.debian.net/debian/developers/artifact/4954901/ Cheers! Sylvain Beucler Debian LTS Team
