Hi ya,

Thanks Simon and Sylvain.

On 2026-11-20 02:47, Sylvain Beucler wrote:
> Hi,
> 
> On 19/11/2026 18:13, Simon Quigley wrote:
>> On 11/19/26 08:42, Luke Yasuda wrote:
>>> I would like to introduce postfixadmin 3.3.13-1+deb12u1 for bookworm- 
>>> security to fix CVE-2026-127178 [0] (#1154298).
>> 
>> Thank you for working on Bookworm as well!
>> 
>>> A DSA for trixie-security hasn't been issued at this moment, but a fix is 
>>> ready and waiting for review from security team. I think it'd be a good 
>>> idea to just copy the text of DSA to DLA.
>>>
>>> It's a small fix. Please see the diff on salsa [1] or download on mentors 
>>> [2]:
>>>
>>> [0] https://security-tracker.debian.org/tracker/CVE-2026-127178
>>> [1] https://salsa.debian.org/debian/postfixadmin/-/commits/bookworm- 
>>> security
>>> [2] dget -x https://mentors.debian.net/debian/pool/main/p/ 
>>> postfixadmin/postfixadmin_3.3.15+ds-2+deb13u1.dsc
>> The fix looks small and reasonable to me, although as a fair warning, I'm a 
>> new member of the LTS Team. A few notes:
>>   - What testing was performed here, for Bookworm?
>>   - Since you're the maintainer, I think "Non-maintainer upload by the LTS 
>> Team." is unnecessary.
>>   - Optionally, do you have DLA text that you would like to use here? 
>> Otherwise, I can prepare something for peer review.
>> 
>> I understand you are a Debian Maintainer, so I am not sure you can upload to 
>> security-master (yet). I would be happy to assist you in driving the 
>> Bookworm side to completion, including sponsorship, reserving the DLA, and 
>> sending the announcement.
>> 
>> Feedback from other LTS Team members (especially from Front Desk) would be 
>> appreciated, in case I'm missing anything.
> 
> That looks good at first glance, pending testing.
> 
> I find the changelog a bit unclear:
> 
> * Correctly use smarty escape:quotes (CVE-2026-127178)
>   This fixes a stored XSS attack when viewing email aliases. A logged in
>   admin may be able to inject aliases.
> 
> "A logged in admin may be able to inject aliases." -> I'd say "a malicious 
> logged-in admin may inject crafted aliases" for the attack, and I suppose add 
> "so as to hijack other admin sessions" as the impact?

Testing: a simple test was done for a simple fix. Before patching, I was able 
to inject JS code by creating a new alias, something like this:

@jing.lgbt@"><script>window.alert("bbbaa")</script>@jing.lgbt

The patched versions do not allow this. It screams "The ALIAS is not valid!". 
The same test is performed on sid, trixie, bookworm and they showed the same 
result.

d/changelog: I removed "Non-maintainer upload by the LTS Team.", I thought I 
had to add this line because the version in bookworm has the name of the 
previous maintainer, before I adopted it.

I also incorporated Sylvain's advice to clarify the changelog entry. It now 
says:

postfixadmin (3.3.13-1+deb12u1) bookworm-security; urgency=high

  * Correctly use smarty escape:quotes (CVE-2026-127178)
    This fixes a stored XSS attack when viewing email aliases. A malicious
    logged in admin may inject crafted aliases to hijack other admin sessions.

For the DLA text, I assumed DSA would be issued first...well, the security team 
has already approved the +deb13u1, but security-master seems to have ignored my 
upload. I'll upload to mentors and file an RFS for trixie-security. Since we 
don't know which one of DSA/DLA will come out first, how about this text, which 
is almost identical to my proposed DSA text:

------------8<-------------
Package        : postfixadmin
Version        : 3.3.13-1+deb12u1
CVE ID         : CVE-2026-127178
Debian Bug     : 1154298

Mirko Vogt discovered that postfixadmin, a virtual mail hosting interface
for Postfix, did not properly validate new aliases or escape quotes when
listing aliases. A malicious logged in admin may inject crafted aliases
to hijack other admin sessions.

For Debian 12 bookworm, this problem has been fixed in version
3.3.13-1+deb12u1.
------------8<-------------

Cheers,
-- 
Luke Yasuda
GPG Fingerprint: 4E09 8D19 00AA 3F72 1899 2614 09B3 316E 13A1 1EFC

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to