Hi Andreas,
On Sat, Jan 28, 2012 at 4:09 AM, Andreas Tille <[email protected]> wrote: > > W: fis-gtm-initial source: syntax-error-in-dep5-copyright paragraph 2 > after > > the field license: Copyright (C) 2007 Free Software Foundation, Inc. < > > http://fsf.org/> > > > > This is correct, the copyright needs fixing. > > > This seems to be a problem with the text of the license > > in the file, that prevents it from being machine readable. > > Yes. It's actually that the license needs to be one > paragraph. If you fill up the empty lines with > . > ( "<blank>.") this should vanish. Would you like to try > > ---------------------------- I'm taking a cut at fixing the copyright file. For this I'm following the guidelines in: http://dep.debian.net/deps/dep5/#license-field The "copyright" file in fis-gtm-initial has two license sections. A) The GTM license, which is AGPL-3.0 B) The debian/* files license, which is GPL-2+ For the case of (A), the full text of the license is in the file, While for (B), only a summary of the GPL2 license is in there, and a reference to the full text in the file: /usr/share/common-licenses/GPL-2 It would seem like a good idea to simplify the text in (A) to the the same as (B). However, in my installation, the directory: /usr/share/common-licenses/ only has: Apache-2.0 Artistic BSD GFDL GFDL-1.2 GFDL-1.3 GPL GPL-1 GPL-2 GPL-3 LGPL LGPL-2 LGPL-2.1 LGPL-3 Then, when searching for a potential AGPL-3 file with apt-file, I get: command: apt-file find AGPL-3 result: r-base-core: /usr/share/R/share/licenses/AGPL-3 r-base-core-ra: /usr/lib/Ra/share/licenses/AGPL-3 Is there a reason why there is not a full AGPL-3 file in a common place ? Should then I leave the full text of the license in the "fis-gtm-initial/debian/copyright" file ? or could I refer to the full text of AGPL at the GNU site: http://www.gnu.org/licenses/agpl.txt ? In the meantime, I follow your advice of using "."s to fill-up the empty lines and convert the full license into a single paragraph. I also replace in line 9 the text: License: AGPL 3 with the recommended short-name from: http://spdx.org/licenses/ as referred here: http://dep.debian.net/deps/dep5/#license-short-name which is: License: AGPL-3.0 My assumption is that in this way it will be better suited to be machine readable. Also, added in line 670 the link to FSF, that seemed to have been truncated from the original version of AGPL. Here is the relevant diff: *************** *** 669,671 **** For more information on this, and how to apply and follow the GNU AGPL, see ! Files: debian/* --- 669,672 ---- For more information on this, and how to apply and follow the GNU AGPL, see ! <http://www.gnu.org/licenses/agpl.txt> ! Files: debian/* With these changes, I run "debuild" in the directory and get the following output (extracting only the lintian-relevant section): Now running lintian... W: fis-gtm-initial source: syntax-error-in-dep5-copyright paragraph 1 after the field license: . Finished running lintian. So... then I opt for being more aggressive and removing the largest portion of the AGPL license, to follow the example of what Thorsten did for the GPL section of the debian/* files. At this point, my new file looks like: ---------------<begin of file>---------------------------- Format: http://dep.debian.net/deps/dep5 Upstream-Name: fis-gtm-initial Source: http://sf.net/fis-gtm/gtm_V(.*)_linux_i686_pro\.tar\.gz Files: * Copyright: 1987 - 2003 Sanchez Computer Associates 1987 - 2011 Fidelity Information Services, Inc Comment: Sanchez Computer Associates was acquired by FIS in 2004 License: AGPL-3.0 This program is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. . This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public License for more details. . You should have received a copy of the GNU Affero General Public License along with this program. If not, see <http://www.gnu.org/licenses/agpl.txt >. Files: debian/* Copyright: 2011 Thorsten Alteholz <[email protected]> License: GPL-2+ This package is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. . This package is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. . You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/> . On Debian systems, the complete text of the GNU General Public License version 2 can be found in "/usr/share/common-licenses/GPL-2". ---------------<end of file>---------------------------- (I also noticed that I was placing the "." chars in the first column, and that Thorsten's section has them in the second column, aligned with the rest of all the text, and so are the examples in: http://dep.debian.net/deps/dep5/#license-short-name, This could have been my mistake in the first place...) After that I run "debuild" again, and this time "lintian" is happy: ..... Now running lintian... Finished running lintian. ..... So, I have a modified version of the "copyright" file ready to commit to SVN. Any objections to committing this "debian/copyright" file in its current form ? Also, are there specific rules regarding the format and content of SVN commit messages ? The policy doesn't seem to have one: and a look at the logs of "debian/copyright" file shows: svn log copyright ------------------------------------------------------------------------ r9379 | tille | 2012-01-22 08:44:10 -0500 (Sun, 22 Jan 2012) | 2 lines Removed missleading appendix -i386 because it also includes amd64 ------------------------------------------------------------------------ r7316 | alteholz-guest | 2011-07-22 13:57:09 -0400 (Fri, 22 Jul 2011) | 1 line just one package for the inital software on i386 and amd64 ------------------------------------------------------------------------ r7204 | alteholz-guest | 2011-06-30 13:52:37 -0400 (Thu, 30 Jun 2011) | 1 line first version of initial binary fis-gtm package ------------------------------------------------------------------------ Thanks Luis
