Hey G.
Copyright is updated.
> debian packaging should be GPL-2+ and not GPL-3+, otherwise you might
> not be able to forward patches back in GPL-2+ mode.
Changed that.
> debian/install with an sh script inside is something that worries me
a little
> bit (even if possible)
>
> can't you please override dh_install in rules?
> I don't like hidden scripts too much
> (instead I would prefer dh-exec)
I'm using that for all the libretro cores, and it was a tip from a
debian dev (I don't remember who, it was months ago).
> check-all-the-things review:
> $ codespell --quiet-level=3
> $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not
find or open any of the paths given.'
> grep -riE 'fixme|todo|hack|xxx' .
>
> also flawfinder shows a lot of stuff.
I'm not sure what to do about this. I can't force upstream write safe
code, I ran flawfinder and found hundred of warnings, I can't really
make a patch to fix that.
cheers,
sergio-br2
