Hello,
I've just uploaded a new version to mentors.
Below are the changelog and answers to your review.
Changes since the last upload:
niceshaper (1.2.2-1) unstable; urgency=low
* New upstream release.
- Introduce overwritable BINDIR variable to Makefile.
- Example configuration files are copied during main installation.
- Make install command doesn't enforce owner nor group of files.
* Drop override_dh_auto_install from debian/rules, export BINDIR instead.
* Drop, no longer needed, debian/niceshaper.install file.
-- Mariusz Jedwabny <mari...@jedwabny.net> Sun, 10 Apr 2016 22:54:45 +0200
On 06.04.2016 11:06, Gianfranco Costamagna wrote:
hi, lets review again
"make DESTDIR=debian/niceshaper PREFIX=debian/niceshaper/usr
BINDIR=debian/niceshaper/usr/bin install"
please let dh_auto_install do its job, and maybe use
something like "DESTDIR?=/usr" or similar to avoid forcing a wrong value.
dh_auto_install should already know about DESTDIR and PREFIX values, in case it
doesn't, just export them in
the rules file.
Done. New version of upstream (1.2.2) was created.
Overwritable BINDIR variable is introduced to Makefile, thus the BINDIR
is exported from debian/rules.
The install file is dropped as well, the Makefile makes his work.
std-version is 3.9.7
Standards version was already bumped to 3.9.7 in 1.2.1-2.
Also, in 1.2.1-2, the manual page was rewritten to be more useful.
dh-systemd the version constraint seems already satisfied even in
old-oldstable-bpo
I'm not sure if it is good or not? I couldn't find any concrete requirement.
check-all-the-things review:
$ codespell --quiet-level=3
$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open
any of the paths given.'
These problems was fixed in 1.2.1-1 version.
The only language problems reported are placed in Polish documents -
these document are for sure proper.
flawfinder -Q -c .
Interesting tool. I will work to try fix some of messages, if possible,
in future versions of upstream.
license is wrong (missing a "+")
the other stuff LGTM, but I didn't check lintian and to build the package
BTW no build system is usually bad ;)
I would like, at least for now, to stay with exactly GPLv2 - without
option of v2.2 or v3.x or whatever.
Thank you for review.
Ciao,
Mariusz
