Markus Koschany <a...@debian.org> writes:
> I had a look at your package and wanted to give you some feedback
> because of the effort you put into packaging this game.
Thank you! Are you a prospective sponsor of this package?
> The vim comments at the bottom are not allowed (syntax-wise)
Those are in end-line comments (“# foo”). My understanding is that
end-line comments with that syntax are permitted in any Debian control
files.
> CC-BY-2.0 is not a DFSG-free license, if possible better use CC-BY-3.0
> or CC-BY-4.0
Thanks. The package includes works I have derived from upstream works
licensed under CC By-2.0.
My understanding of the problems with CC licenses version 2.0 is in the
potential for some licensors to set impractical restrictions on
attribution. That is not the case for any of these specific works, so I
think they are DFSG-free currently.
To avoid such problems arising for the derived works, I will set the
license to CC By-4.0 in those derived works as distributed in Debian.
> You have patched the upstream sources (12 patches). In general the
> patches look O.K but I wonder if they are all necessary. Did you
> forward them upstream? Why do you think Debian should diverge from
> upstream?
Those patches turn the work into a useable stand-alone program for
Debian. Each one is submitted upstream, and I'm corresponding with the
upstream maintainer to get these changes incorporated.
> You split the game into three arch:all binary packages. I'm not
> totally convinced that this is really necessary for a game like
> python-adventure. Your current approach is not totally wrong either,
> perhaps a bit too perfectionist though. Are there strong reasons why
> you split the game into three parts?
I would think rather that conforming to Debian policy would be the
default, and a divergence would need a strong reason.
> Why don't you join the Python or Games Team and maintain
> python-adventure within one of these teams?
No particular reason. I am enjoying maintaining the code as it is.
> I found the following things with check-all-the-things:
>
> colossal-cave-adventure.desktop: found with desktop-file-validate
> error: value "adventure;advent;colossal;cave;spelunk" for locale string
> list key "Keywords" in group "Desktop Entry" does not have a semicolon
> (';') as trailing character
Thank you. I formed that field just by copying others. Is there a
specification for that field that I've missed?
> codespell --quiet-level=3
> ./adventure/advent.dat:996: KNIVE ==> KNIFE
> ./adventure/advent.dat:1462: THRU ==> THROUGH
>
> Might be intentional since it's the original game dialogue.
Yes, that's right; the purpose of the package is to present the original
game data and dialogue.
> pep8 --ignore W191 . found something that could be improved. Nothing
> critical but it could be forwarded upstream.
>
> pyflakes3 .
> ./adventure/__main__.py:10: 'readline' imported but unused
Thanks, I will work with upstream on code style over time.
--
\ “If you don't fail at least 90 percent of the time, you're not |
`\ aiming high enough.” —Alan Kay |
_o__) |
Ben Finney
