Hi, well, as Mattia said, we already have the -g injected by dpkg-builflags, so 
no action is needed

dpkg-buildflags --get CXXFLAGS
-g -O2 -fstack-protector-strong -Wformat -Werror=format-security

g.





Il Lunedì 4 Aprile 2016 15:39, Gianfranco Costamagna 
<costamagnagianfra...@yahoo.it> ha scritto:
Hi Frank,

nobody usually sponsors stuff without an RFS bug.

And sending a mail with RFS in the subject isn't a bug :)

anyhow, lets review:
"CXXFLAGS = -std=c++11 -O3"

I think you shouldn't force -O3 and for sure you shouldn't override external 
flags.

Please do += instead of =
or maybe ?=
also for BIN *FLAGS

usually LDFLAGS are linker flags, while LIBS are linked libraries.
so please use LIBS instead.
$(CXX) $(CXXFLAGS) $(SOURCES) $(LDFLAGS) -o $(PROGNAME) $(LIBS)

might do the trick.

control: std-version is 3.9.7
some b-d might be useless
"libboost-all-dev" is it useful?

insecure VCS fields

check-all-the-things:

$ codespell --quiet-level=3
./TODO:13: comparision  ==> comparison



copyright:
"the work is not subject to copyright in any jurisdiction."

this license seems not possible.
You cannot force jurisdiction to not copyright your stuff.

please choose a better licensing text, IANAL but this might be rejected
by ftpmasters

maybe unlicense might be a good license
http://unlicense.org/

please add a watch file.


the other stuff looks good, please ping when you have addressed the above.

cheers,

G.






Il Mercoledì 17 Febbraio 2016 19:49, Frank Stähr <der-storch...@gmx.net> ha 
scritto:
Hello everybody,

unfortunately nobody seems to be interested in sponsoring my package 
setop, so I updated my upload to increase quality.

Besides some spelling errors (that will be removed with my next update) 
there are still a "Watch file is not present" message and some lintian 
informational warnings, namely "no-upstream-changelog", 
"hardening-no-bindnow", and "hardening-no-pie". Please tell me if it is 
necessary to get rid of them all or if there is something else wrong.

Because no one is yet convinced of setop, once again a description:
setop is a simple console application for scientific working and 
advanced scripting. I already needed it twice at work and noticed that 
there is nothing similar. There are also some websites explaining 
workarounds for getting set operations, see e. g.
<http://unix.stackexchange.com/questions/11343/linux-tools-to-treat-files-as-sets-and-perform-set-operations-on-them>
where you can also find programming and scripting attempts from other 
users to fill the gap.

Am 04.02.2016 um 17:56 schrieb Frank Stähr:
> Alternatively, one can download the package with dget using this command:
>
> dget -x http://mentors.debian.net/debian/pool/main/s/setop/setop_0.1-1.dsc

Some possible features are intentionally missing (disjoint, power set, 
minimum, …) but may be added if requested and sensible, I am open for 
suggestions :-) (perhaps not here on the list but on Github).



Regards,
Frank

Reply via email to